main #169
main #169
Conversation
|
|
27 similar comments
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
The Turkish National Identification Number (NIN) consists of 11 digits in the format NNNNNNNNNNN where the last two digits are check digits. The Vergi Kimlik Numarasi (VKN) is a 10-digit number in the format NNNNNNNNNN. The Vergi Kimlik Numaras is the Turkish tax identification number used for businesses and certain foreign individuals. closes #187228 Task: 4282883 X-original-commit: 7d6a111 Signed-off-by: Wala Gauthier (gawa) <gawa@odoo.com> Signed-off-by: Maximilien La Barre (malb) <malb@odoo.com>
Product images are lazy-loaded on the cart page, causing them to be displayed later than the rest of the page. As a result, some parts of the page were shifted once the image was loaded (since the image had no size before loading). This change wraps the image in a fixed-size container to avoid the layout shift. Incidentally, this change also fixes some alignment issues when the cart contains images with various aspect ratios. opw-4029017 closes #187297 Signed-off-by: Louis Tinel (loti) <loti@odoo.com>
Before this commit: Pasting content within `blockquote` and `pre` elements resulted in each node being converted into separate `blockquote` or `pre` elements. After this commit: `blockquote` and `pre` should be considered like wrappers, allowing paragraph-related elements to be pasted inside them. task-4154465 Part-of: #187312 Signed-off-by: David Monjoie (dmo) <dmo@odoo.com> Signed-off-by: Deependra Solanki (deso) <deso@odoo.com>
Before this commit: When pasting the clipboard content as plain text (CTRL+SHIFT+V) inside a `PRE` element would convert each line break into a new paragraph. After this commit: When pasting the clipboard content as plain text within `PRE`, every new line should be pasted within the pre tag. task-4154465 Part-of: #187312 Signed-off-by: David Monjoie (dmo) <dmo@odoo.com> Signed-off-by: Deependra Solanki (deso) <deso@odoo.com>
The <pre> tag does not have automatic word-wrapping or line-breaks as it is intended to keep the formatting of the text. This commit ensures that long text within <pre> tags does not overflow. task-4154465 Part-of: #187312 Signed-off-by: David Monjoie (dmo) <dmo@odoo.com> Signed-off-by: Deependra Solanki (deso) <deso@odoo.com>
Before this commit: When text with a url is pasted within a pre tag the text is converted to a link. After this commit: When text with a url is pasted within a pre tag it should not convert it to a link. task-4154465 closes #187312 Signed-off-by: David Monjoie (dmo) <dmo@odoo.com> Signed-off-by: Deependra Solanki (deso) <deso@odoo.com>
When a lot of sale orders are making one big invoice, the invoice_origin field which is used in the DescripcionFactura in Ticketbai and contains the list of all the sale orders in text will be too long (should be max 250 chars length) We simply shorten to 250 chars. Reported by Rafael Blasco, Moduon (MT-8041) closes #187332 Signed-off-by: Ruben Gomes (rugo) <rugo@odoo.com>
|
|
|
|
The issue: Before this commit, the product was intended to be set as 'invoice on order', but this wasn't applied. The status was overridden due to the '_compute_invoice_policy' function override in the 'l10n_ke_edi_oscu_stock' module, which caused the test to fail on runbot when this module is installed. The fix: Put the product to 'invoice on order' before creating the sale order runbot-70731 closes #187280 Signed-off-by: Tiffany Chang (tic) <tic@odoo.com>
`BLOCK` button in the workcenter blocking wizard should be in lowercase closes #187384 Signed-off-by: Quentin Wolfs (quwo) <quwo@odoo.com>
Steps to reproduce:
- Enable Analytic Accounting and Anglo-Saxon Accounting in the settings
- Create a storable product
- Set inventory valuation to Automated on the product's category
- Add a cost to the product
- Create an invoice with the product and add an analytic distribution
- When the invoice is confirmed, the distribution is also applied to
the CoGS line.
For example, in an invoice where the product’s sale price equals its cost,
the account plan will show a balance of 0 (debit = credit).
After this fix, the account plan will show a balance of 10.
Task 2008567 led to the commit 3590efa,
which removed the analytic distribution from the stock interim account.
However, the expense line was not modified accordingly.
opw-4177695
closes #187361
X-original-commit: 13abc6e
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Louis Gobert (loug) <loug@odoo.com>
Versions -------- - 16.0+ Steps ----- For 17.0+: 1. Create a Sale Order for a new contact without phone number; 2. disable online signature; 3. add a deliverable product to the SO; 4. hit "Send by Email"; 5. open the sent mail (e.g. via Mailhog); 6. copy the payment link; 7. open in Safari on iOS; 8. pay the sales order. Issue ----- > TypeError: Attempted to assign to readonly property. > extractFilteredSchemaValuesFromMicroData@https... > extractSchemaValuesFromSchemaOrg@https... > global code@https... Cause ----- `extractFilteredSchemaValuesFromMicroData` is a function internal to iOS Safari. It is bugged in that it tries to reassign a `const` in some scenarios where no elements with `itemprop="telephone"` attributes are found. Solution -------- If the contact doesn't have a mobile or phone number, add an empty `div` with `itemprop="telephone"`. opw-4072838 closes #187380 X-original-commit: f2406e2 Signed-off-by: Rémy Voet (ryv) <ryv@odoo.com> Signed-off-by: Levi Siuzdak <sile@odoo.com>
|
|
When we try to print multiple invoice who have multiple pages and have
H2 title in the comments, the system treats the document as separate files,
resulting in error: `AttributeError: 'NoneType' object has no attribute 'getValue'`.
Steps to reproduce:
- Create an invoice without any attachment.
- Create another invoice, ensuring that its printout spans multiple pages,
and add an H2 title in the comments (narration).
- In the list view, attempt to print both invoices.
- Ensure that the report being printed contains a value in the
"Save as attachment prefix" field.
The issue arises because the presence of multiple H2 headings causes the
system to treat the document as separate files. Consequently, the condition
`if has_same_number_of_outlines and has_top_level_heading:`` is not
satisfied, which results in a stream to be None.
opw-4247013
closes #187369
X-original-commit: b127643
Signed-off-by: Rémy Voet (ryv) <ryv@odoo.com>
Signed-off-by: Louis Gobert (loug) <loug@odoo.com>
Steps to reproduce: - In Website edit mode. - Drag and drop a "Text" block into the page. - Click on the first paragaph of the "Text" block. - click the "Insert media" button of the text toolbar. - A traceback occurs. The bug was introduced in commit [1], where we checked that "this.props.media" was not undefined before calling the "closest" function on it. However, this was incorrect because, in cases where "this.props.media" was false, the "closest" function was still called, causing the traceback. With this fix, the "closest" function is not called if "this.props.media" is false. [1]: 625c1aa opw-4335833 opw-4328280 opw-4334279 opw-4328490 opw-4334012 opw-4332500 opw-4332028 opw-4332684 opw-4329687 opw-4331635 opw-4331371 opw-4331287 opw-4332437 opw-4331144 opw-4329646 opw-4328364 opw-4323197 opw-4325959 opw-4322945 closes #187406 Signed-off-by: Colin Louis (loco) <loco@odoo.com>
This reverts [1] commit b45e249. Steps to reproduce: - Enable Multi-step routes - Create a storable product: put 5 units on shelf 1 and 5 on shelf 2 - Create and "mark as todo" a delivery order for 3 units - Click on the detailed operation and change the reservation from shelf 1 to shelf 2 > save (the subrecord not the record) - Reopen the details operation > The records get resets in front of you Cause of the issue: One of the main problems of [1] is that it modifies dirrectly the data's of the props of the component used by the X2many dialog: https://github.com/odoo/odoo/blob/7e01d83ac08f9b076e0cd7d7e644679d5264ff7d/addons/stock/static/src/fields/stock_move_line_x2_many_field.js#L48 As such, as soon as you mount that component, you will reset the data's used by that same component. Worse, the component is doing this to itself. Hence, if you did not perform a save before opening the details operation you will reset the values to match the DB's data. Furthermore this data change modifying the props of the component we are looking at will force to reload the component with the newly hardcoded data (which explains that you see your last change resetting in front of you). In addition, the `quant_id` field of the stock.move.line model is a very particular field as it is neither stored or computed but is used by the create and the write for the stock.move.line data's to match some of the quant informations: https://github.com/odoo/odoo/blob/7e01d83ac08f9b076e0cd7d7e644679d5264ff7d/addons/stock/models/stock_move_line.py#L85 https://github.com/odoo/odoo/blob/7e01d83ac08f9b076e0cd7d7e644679d5264ff7d/addons/stock/models/stock_move_line.py#L310-L311 Therefore this field will never be set on a move. line that was not modified in JS and is not saved yet. In order to take into account the offset between the DB Data and the data's we are setting on the form of stock move it is therefore necessary to perform an rpc to **guess** what quant was used to create a given line. HOWEVER, as teached by the JS framework formation: ``` The first rule of customizing Odoo in JS is: do it in python ``` So that you should not do that matching in JS but rather where it belongs. Finally, modifying the props of a componenet during the onMounted is a super hacky way to use OWL as it is the first Hook for which OWL does not destroy the componenet because of props inconsistency... + this commit already required an other fix: Commit ea4fca8 opw-4294650 Part-of: #186400 Signed-off-by: William Henrotin (whe) <whe@odoo.com>
In the form picking view, it is possible to edit the move lines that are related to a given move by using the `SMLX2ManyField`. However, untill you save the record, available quantity of quants present in the DB are not updated. This commit ensures that the quants poposed for your move line creation have an available quantity (even if currenlty dirty) and that the quantity used for the next move line creation is both related to the demand of the move, and the real availability of the quant used to create it. The initialy reported issue of the reverted commit was the following: Steps to reproduce - In the setting enable Multi Step Routes - Create a storable prodcut and put 5 units on shelf 1 - Create and Mark as Todo a delivery order for 3 units of your product - Set the quantity of the move to 0 and save the record - Click on the "burger list icon" of the stock move to edit the detailed operations and make the reservations for your 3 units - We want to make the reservation in 2 lines targetting the same quant - Add a new line selecting your shelf 1 quant and set the qty to 1 - Try to add a second one the quant is not proposed Cause of the issue: When a quant has been selected at least once and the record is not yet saved the js data of the record contains the info of the quant used to create/update the move line because of the non stored not computed dummy field `quant_id` of the stock move. As such the quant will be considered to already having been used in this transaction and hence not available: https://github.com/odoo/odoo/blame/54e06a1b25ed9e317e368e89979c7c77ddbffc08/addons/stock/static/src/fields/stock_move_line_x2_many_field.js#L52-L54 opw-4072541 closes #186400 Signed-off-by: William Henrotin (whe) <whe@odoo.com>
|
|
|
|
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr