Saas 17.4 #176
Open
Saas 17.4 #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
19 similar comments
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Open
|
|
7 similar comments
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Issue:
- When a database is set to a language other than English,
the 'Expected Date' for product replenishment does not adapt
according to the set vendor lead time.
This issue does not occur when the database is set to English.
Steps To Reproduce:
- Create a storable product.
- Define a vendor for this product and add a delivery lead time.
- Navigate to the product template and click on the "Replenish" button.
- Observe that in an English language setting, the schedule date is
calculated correctly considering the vendor's delivery lead time.
- Change the language of the database to a different language.
- Repeat the replenish process.
- Observe that the schedule date is not calculated correctly.
Solution:
- Replaced route name check with action check in `_get_date_planned`
for better reliability, as action-based conditions reduce errors
compared to route name comparisons.
opw-4199660
closes #187084
X-original-commit: 387cd9a
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Kawtar Drissi El Bouzaidi (kdeb) <kdeb@odoo.com>
If user wanted to filter products by more than one attribute, after going to the next page, second attribute filter was deleted. opw-4191891 closes #187107 Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
Currently if you try to modify the quantity of a combo product from the cart in the kiosk, the price will not update. Steps to reproduce: ------------------- * Open a kiosk * Add a combo product to the order * Go to review the order * Click on the + button > Observation: The price of the order does not change. Why the fix: ------------ In the backend we can see that the parent quantity was changed accordingly but the child products quantity stayed at 1. We were not accessing the right field when checking the child products. opw-4283481 closes #187257 Signed-off-by: David Monnom (moda) <moda@odoo.com>
Steps to reproduce the issue: ============================= - Go to any chatter - Open email composer - Add seperator - Send - The seperator doesn't appear Origin of the issue: ==================== The issue was first introduced by [1] where we wanted to simplify the border-width to use only the style of 1 but it doesn't work correctly for `hr` element. We keep all border-with styles as grouping them all in one style can lead to very different ui. opw-4300018 [1]: 3763d0e closes #186541 Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
The rounding method 'HALF-UP' is confusing for regular users when they see it in the UI. Replacing the user-facing term by the less specific 'Nearest' is clearer, since people naturally expect that to round halves up. Also the other UI strings were in all caps and have been changed to capitalized strings. opw-4266444 closes #187209 X-original-commit: 9ea529e Related: odoo/enterprise#73804 Signed-off-by: Dylan Kiss (dyki) <dyki@odoo.com>
…voice analysis report In a previous commit: #151805, the goal was to add margin to the account invoice report. No negative margins were possible before because it didn't take the customer's credit notes. This is now fixed with this commit, that aims to add customer's credit note to margin calculations task-4167630 closes #186952 X-original-commit: ed8b35c Signed-off-by: Olivier Colson (oco) <oco@odoo.com> Signed-off-by: Logan Staelens (lost) <lost@odoo.com>
When adding a rules in loyalty program that had a product set, if you try to refund an order containing this product you would get an error Steps to reproduce: ------------------- * Create a loyalty program with a rules that has product_ids set to any product. * Open PoS and make an order with the product set on the loyalty program * Validate the order * Try to refund the order > Observation: You get an error saying you cannot refund giftcards or eWallets Why the fix: ------------ This was happening because `trigger_product_ids` is related to `rule_ids.product_ids`. And when checking if a product is a giftcard or eWallet we first checked that `trigger_product_ids` was set. Now we only check the type of the program linked to a product. opw-4206226 closes #187231 X-original-commit: 1ce8283 Signed-off-by: Vlad Stroia (vlst) <vlst@odoo.com> Signed-off-by: Robin Engels (roen) <roen@odoo.com>
|
|
…pany branches To reproduce the issue: 1) Create a company A, with a branch B 2) Define a currency rate for A, for currency C 3) Open currency C's form view with only B as active company ==> The rate created in 2) is not shown Branch companies use the rates defined on their root, so it should be displayed here. closes #187309 X-original-commit: 8bed71d Signed-off-by: William André (wan) <wan@odoo.com>
When a user visits a product page, the product gets marked as "recently viewed" after 8 seconds. This delay is too long, as a user can realistically view the product and navigate away before the 8 seconds have passed (in which case the product isn't marked as recently viewed). In particular, this is problematic when the website contains a "recently viewed products" carousel, where the user expects to see all products they recently viewed (even if they didn't stay on the product page for 8 seconds). We decided to reduce the delay to 0.5 seconds, which is long enough to prevent the product from being marked as "recently viewed" if the user visits a product page by mistake and immediately navigates away, but short enough to prevent problematic behaviors such as the one mentioned above. opw-4114364 closes #187298 X-original-commit: 7528304 Signed-off-by: Louis Tinel (loti) <loti@odoo.com>
Steps: - Create a dynamic attribute with some attribute Lines - Create a product with attributes set to the new attribute - Change cost price and save - Reload the webpage Issue: - Cost price changes back to 0 Cause: - `_compute_template_field_from_variant_field` is called on `_compute_standard_price` which sets the value of field to default (false) for variant_count=0 Fix: - Cost price will be invisible for variant_count=0 opw-4054647 closes #187308 X-original-commit: 7f24aa1 Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com> Signed-off-by: Dev Reshamiya (dere) <dere@odoo.com>
When modifying an existing order in the PoS the sales team would be unset. Steps to reproduce: ------------------- * Open a table and add some items to it * Leave the table and go back on it 2 times * Validate the order > Observation: Go on the sale report and group by sale team, your order will appear under the "None" section Why the fix: ------------ We make sure that when we write on the order we will the values of the crm team defined on the pos config opw-4232473 closes #184585 Signed-off-by: David Monnom (moda) <moda@odoo.com>
Some users are using custom domains in their loyalty programs. This include using fields that are not loaded in the PoS. This will fix the specific usecase of one client. But this could be improved and fields should be loaded dynamically based on the needed fields. opw-4262960 closes #187230 X-original-commit: 4b88c7e Signed-off-by: Vlad Stroia (vlst) <vlst@odoo.com> Signed-off-by: Robin Engels (roen) <roen@odoo.com>
Part-of: #187229 Signed-off-by: William Henrotin (whe) <whe@odoo.com>
closes #187229 Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Steps to reproduce: - Install "l10n_ch" and switch to the Swiss company - In the Accounting settings activate the QRcodes on invoices - Change the name of the Swiss company - Create an invoice - The old company name is still displayed next to the QR code Cause: The field displayed is the field `account_holder_name` which is not updated when changing the company name. Solution: As the field `account_holder_name` is not supposed to be shown anymore in 18.0, we can display directly the partner name. opw-4273688 closes #187128 X-original-commit: 30db866 Signed-off-by: John Laterre (jol) <jol@odoo.com> Signed-off-by: Mathieu Coutant (mcou) <mcou@odoo.com>
*: pos_sale, pos_loyalty, pos_restaurant, pos_event Before all lines was sent to the backend to be processed, if the backend had a line that wasn't sent by the frontend, it was removed from the order. Now the frontend sends only modified lines to the backend, if a line is deleted from the frontend, it will be deleted from the backend too. But the backend doesn't remove lines that weren't sent by the frontend. This change was made to avoid losing information when the backend delete a line that wasn't sent by the frontend. This commit should also resolve the loss of orders when to different devices try to add an order on the same table at same time. Cherry-picked from bdd57e0 closes #187268 Signed-off-by: Vlad Stroia (vlst) <vlst@odoo.com>
Steps to reproduce:
- Enable Analytic Accounting and Anglo-Saxon Accounting in the settings
- Create a storable product
- Set inventory valuation to Automated on the product's category
- Add a cost to the product
- Create an invoice with the product and add an analytic distribution
- When the invoice is confirmed, the distribution is also applied to
the CoGS line.
For example, in an invoice where the product’s sale price equals its cost,
the account plan will show a balance of 0 (debit = credit).
After this fix, the account plan will show a balance of 10.
Task 2008567 led to the commit 3590efa,
which removed the analytic distribution from the stock interim account.
However, the expense line was not modified accordingly.
opw-4177695
closes #187385
X-original-commit: 13abc6e
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Louis Gobert (loug) <loug@odoo.com>
**Steps:** - Create a new pricelist - Apply pricelist rules - For eg: Apply it on Acoustic Bloc Screen, with a fixed price of 20. - When seen on the shop page or product page, it shows a strikethrough price along with the original price - Same happens when we use formula instead of fixed price. **Changes:** Changed some test cases because currently, the pricelist had fixed price which was causing the strikethrough to not appear. But due to the code change, it will now not appear, hence giving the percentage price to the tour to run it smoothly. **Before this commit:** The strikethrough prices on the shop page were shown for all the pricelist rules **After this commit:** The strikethrough prices are now shown everywhere only if the pricelist rule is a 'discount'. Formula based discount rules strikethrough prices are also displayed on the shop/configurator and product pages, but not on the cart and subsequent steps of the checkout to allow customer to apply discounts while still keeping 'beautiful' prices. **Affected version:** saas-17.4~master opw-4181825 closes #181014 Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
Steps to reproduce the issue: ============================= - Set the company of the website to one that uses (euro) currency. - Open the website editor - Drag a banner block and a products carousel block under it - Set the last template to the products block (last one in the list) - Try to edit the title of the banner block - One of two keystrokes are reverted Origin of the issue: ==================== When we added content, we do historyStep which calls sanitize on the target (the editable), which will sanitize the non editable elements inside it and have `oe_unremovable`. observerApply now will mark this._toRollback as true so in the next keystroke it will revert the changes and so on... Solution: ========= We should not unwrap content for `oe_currency_value` spans opw-4252743 closes #187321 X-original-commit: 53e547e Signed-off-by: David Monjoie (dmo) <dmo@odoo.com> Signed-off-by: Mahdi Cheikh Rouhou (macr) <macr@odoo.com>
The issue: When a manufacturing order has a large quantity to produce (or a decimal accuracy with several digits), in Done status, the fields qty_producing and product_qty overlap. How to reproduce the issue: - Create a manufacturing order, and set quantity to produce to a large number (ex: 20000000000) - Confirm and Produce all opw-4237620 closes #186823 X-original-commit: 8801e65 Signed-off-by: Steve Van Essche <svs@odoo.com> Signed-off-by: Guillaume Teboul-Tornezy (gute) <gute@odoo.com>
To reproduce: Go to Accounting/Invoicing, Customers and create a new Customer. Delete it. You get an error talking about audit trail while you don't have it activated. The issue is that we block based on customer/supplier rank when there is no company on the partner. We now check if we should block the deletion of a message of a partner if this partner has at least one journal entry with a company that has audit trail activated. closes #187151 X-original-commit: e1b3e1a Signed-off-by: William André (wan) <wan@odoo.com> Signed-off-by: Wala Gauthier (gawa) <gawa@odoo.com>
Follow-up of #185583 PR above fixed an issue that results in a traceback when posting a message with `@`mention in multi-company. This happens because a message post with `@`mention notifies the recipients of new message in their inbox, but the computing of this notification was made in the context of the recipient but with `allowed_company_ids` of the person that sends the message. If the recipient does not have access to the `allowed_company_ids` of the sender then this leads to the crash that PR above fixes. The PR fixed it by removing the `allowed_company_ids` from the context, with `allowed_company_ids=None`. However, some code inspect presence of `ctx.allowed_company_ids` with the following code: ```py len(self.env.context.get('allowed_company_ids', [])) <= 1 ``` Due to `allowed_company_ids` being present as `None`, code attempts to `len(None)` which is invalid thus it crashes. This commit fixes the issue by passing `[]` as allowed_company_ids. This is semantically the same as passing no `allowed_company_ids` but it prevents crash from the pattern above. opw-4231529 closes #187393 Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
When we try to print multiple invoice who have multiple pages and have
H2 title in the comments, the system treats the document as separate files,
resulting in error: `AttributeError: 'NoneType' object has no attribute 'getValue'`.
Steps to reproduce:
- Create an invoice without any attachment.
- Create another invoice, ensuring that its printout spans multiple pages,
and add an H2 title in the comments (narration).
- In the list view, attempt to print both invoices.
- Ensure that the report being printed contains a value in the
"Save as attachment prefix" field.
The issue arises because the presence of multiple H2 headings causes the
system to treat the document as separate files. Consequently, the condition
`if has_same_number_of_outlines and has_top_level_heading:`` is not
satisfied, which results in a stream to be None.
opw-4247013
closes #187390
X-original-commit: b127643
Signed-off-by: Rémy Voet (ryv) <ryv@odoo.com>
Signed-off-by: Louis Gobert (loug) <loug@odoo.com>
…dispath The downpayment moves need to be reported in the FatturaCollegate and also as real negative lines in the XML. That worked in 16, but as we added the dispatch of the negative lines on the line discounts of the positive lines, the negative downpayment linked line got swallowed by the dispatch. The fix is to not dispatch downpayment linked lines. opw-4274292 closes #187125 X-original-commit: dc493b5 Signed-off-by: Wala Gauthier (gawa) <gawa@odoo.com> Signed-off-by: Josse Colpaert (jco) <jco@odoo.com>
Product images are lazy-loaded on the cart page, causing them to be displayed later than the rest of the page. As a result, some parts of the page were shifted once the image was loaded (since the image had no size before loading). This change wraps the image in a fixed-size container to avoid the layout shift. Incidentally, this change also fixes some alignment issues when the cart contains images with various aspect ratios. opw-4029017 closes #187422 X-original-commit: 1715723 Signed-off-by: Louis Tinel (loti) <loti@odoo.com>
The UBL file could contain SO or PO information if the invoice is linked to one. The MyInvois platform does not support this information and return a validation error if it is provided. This fix will update the template in order to remove this information from the file. closes #187367 X-original-commit: a620727 Signed-off-by: de Wouters de Bouchout Jean-Benoît (jbw) <jbw@odoo.com> Signed-off-by: Nicolas Viseur (vin) <vin@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr