remove pins on werkzeug, itsdangerous and markupsafe since they are currently not needed #2565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urrently not needed
imatiach-msft
requested review from
gaugup,
xuke444,
kicha0,
RubyZ10,
vinuthakaranth and
tongyu-microsoft
as code owners
jeff-shepherd
approved these changes
May 15, 2024
tongyu-microsoft
approved these changes
May 15, 2024
|
merging this for now as builds are broken due to unrelated reason, will send separate PR for broken builds (macos) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing pins on werkzeug, itsdangerous and markupsafe since they are currently not needed.
Some of these were added about a year ago to fix build breaks:
#1238
However these issues have been resolved and we should not be pinning them but instead rely on flask to pin to the correct versions unless we encounter issues again.
Otherwise, downstream customers are seeing problems with our pins being too restrictive.
Checklist