Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade flask to resolve notebook error " ImportError: cannot import name 'url_quote' from 'werkzeug.urls'" #2577

Closed
wants to merge 2 commits into from

Conversation

tongyu-microsoft
Copy link
Contributor

For ImportError: cannot import name 'url_quote' from 'werkzeug.urls', since we pinned werkzeug>=3.0.3 to fix the vulnerability issue on wekzeug, and the url_quote function was removed in Werkzeug version 3.0.0, we need to upgrade the Flask version to be compatible with the Werkzeug version 3.0.3.

Description

Checklist

  • I have added screenshots above for all UI changes.
  • I have added e2e tests for all UI changes.
  • Documentation was updated if it was needed.

@@ -1,4 +1,4 @@
Flask
Flask>=3.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should already be getting the latest flask version since there is no pin here - so the question is what is downgrading flask instead of getting the latest version?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. I thought import error was resolved after pining Werkzeug >= 3.0.0

1 similar comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants