Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use ReadLineAsync from polyfill #3837

Closed
wants to merge 6 commits into from
Closed

use ReadLineAsync from polyfill #3837

wants to merge 6 commits into from

Conversation

SimonCropp
Copy link
Contributor

No description provided.

@SimonCropp
Copy link
Contributor Author

whats the failed test?

Evangelink
Evangelink requested changes Sep 15, 2024
View reviewed changes
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have dropped too much code, the read is fully gone.

@SimonCropp
Copy link
Contributor Author

@Evangelink i think it is still there ? https://github.com/microsoft/testfx/pull/3837/files#diff-09ebded200ee21d2dd09a73b0b6410a3bb42afd5a601763ac2c4290b0a829477R90

@Evangelink
Copy link
Member

I am just blind... Sorry

@Evangelink Evangelink enabled auto-merge (squash) September 21, 2024 15:16
Evangelink
Evangelink reviewed Sep 24, 2024
View reviewed changes
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cancellation token seems to not be working as expected. The tests are failing because of some hangs.

@Evangelink
Copy link
Member

I can reproduce locally the hang, I'll try to have a look at what's hanging tomorrow.

@SimonCropp
Copy link
Contributor Author

perhaps a bug in my polyfill code?

@Evangelink
Copy link
Member

@SimonCropp I don't know if that's a bug per say but for sure your implementation only look at the token as the entry of the method:
image

while your implementation do check it during the execution.

Evangelink
Evangelink requested changes Sep 25, 2024
View reviewed changes
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The refactoring is causing a functional difference that can lead to hangs.

@Evangelink Evangelink closed this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evangelink Evangelink Evangelink requested changes

@MarcoRossignoli MarcoRossignoli Awaiting requested review from MarcoRossignoli MarcoRossignoli is a code owner

Assignees

@SimonCropp SimonCropp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonCropp @Evangelink