Support rsp in MTP #4072
Open
Support rsp in MTP #4072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Area: Testing Platform
Youssef1313
force-pushed
the
support-rsp
branch
5 times, most recently
from
8ee8e46
to
41d38e8
Compare
Youssef1313
force-pushed
the
support-rsp
branch
from
41d38e8
to
fce6c4b
Compare
Youssef1313
requested review from
MarcoRossignoli and
Evangelink
as code owners
src/Platform/Microsoft.Testing.Platform/CommandLine/ResponseFileHelper.cs
Outdated
Show resolved
Hide resolved
| new("option4", ["d"]), | ||
| new("option5", ["e"]), | ||
| new("option6", ["f"]), | ||
| }.ToArray(), [])); |
There was a problem hiding this comment.
pls add a pair of more sample with
- rsp file at the start
- rsp file t the end
- only rsp file
- 2 rsp file only
Evangelink
reviewed
Nov 18, 2024
| // - https://github.com/dotnet/command-line-api/blob/feb61c7f328a2401d74f4317b39d02126cfdfe24/src/System.CommandLine/Parsing/StringExtensions.cs#L349 | ||
| internal static class ResponseFileHelper | ||
| { | ||
| internal static bool TryReadResponseFile(string rspFilePath, List<string> errors, [NotNullWhen(true)] out string[]? newArguments) |
There was a problem hiding this comment.
Nit: let's use higher abstraction for errors.
Suggested change
| internal static bool TryReadResponseFile(string rspFilePath, List<string> errors, [NotNullWhen(true)] out string[]? newArguments) | |
| internal static bool TryReadResponseFile(string rspFilePath, ICollection<string> errors, [NotNullWhen(true)] out string[]? newArguments) |
| newArguments = null; | ||
| return false; | ||
|
|
||
| static IEnumerable<string> ExpandResponseFile(string filePath) |
There was a problem hiding this comment.
Stylistic nit:
Suggested change
| static IEnumerable<string> ExpandResponseFile(string filePath) | |
| // Local functions | |
| static IEnumerable<string> ExpandResponseFile(string filePath) |
|
|
||
| static IEnumerable<string> ExpandResponseFile(string filePath) | ||
| { | ||
| string[] lines = File.ReadAllLines(filePath); |
There was a problem hiding this comment.
Could it be worth reading async (cc @MarcoRossignoli)?
| } | ||
| catch (IOException e) | ||
| { | ||
| errors.Add(string.Format(CultureInfo.InvariantCulture, PlatformResources.CommandLineParserFailedToReadResponseFile, rspFilePath, e.Message)); |
There was a problem hiding this comment.
It might be worth adding the tostring of the exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3730