-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add per-extension incognito mode #157
base: main
Are you sure you want to change the base?
Conversation
You need to consider the fact that source can change id and extensions can also have new source |
This comment was marked as outdated.
This comment was marked as outdated.
I guess removing the sources from the list when the extension is uninstalled is also a good idea, else we would have a bunch of orphan source ids that do not belong to any extension. |
Bumping, because I wanted to know if there is anything you want me to do else, or if this is only stalled because you want to implement other stuff before this. |
Since I find this feature really useful and timesaving, @MajorTanya is there any reason why this is stalled? |
First: please don't ping random people into PRs, especially when they have not even been there before. Second: I have no control over what gets accepted or not, and there may be any number of reasons for stuff to be stalled. You coming in to necropost is neither helping nor welcome. No, this is not an invitation to ping AntsyLich instead or anything else. Either it will be accepted at some point or it won't. Until such time, you'll have to wait. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally instead of saving each source ids we could potentially resolve the IDs whenever we initialize an extension? Something like a new class that listens for changes in available extensions filters them by incognito disabled extension and maps to the IDs of sources inside them.
app/src/main/java/eu/kanade/domain/source/interactor/ToggleSource.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceScreenModel.kt
Outdated
Show resolved
Hide resolved
address change requests
Honestly I do not quite know what exactly you mean by this... |
This PR adds a per-extension incognito mode toggle. With this you can more or less "automate" using the incognito mode as oftentimes there are only specific extensions (heh) where you need it.
Image