Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial updates for Operator v5.0.7 docs #978

Merged
merged 4 commits into from
Aug 31, 2023
Merged

Partial updates for Operator v5.0.7 docs #978

merged 4 commits into from
Aug 31, 2023

Conversation

Copy link
Collaborator

@ravindk89 ravindk89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM mod one small nit.

.. mc-cmd:: --dangerous
:optional:

Safety flag to confirm deletion of the MinIO Operator and all tenants with :mc-cmd:`~kubectl minio delete --force`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I recall correctly, this may also delete the PVC and PV underlying if the PVC retention isn't set to retain - https://kubernetes.io/docs/concepts/storage/persistent-volumes/#reclaim-policy

Maybe worth warning here and confirming with someone on the K8s team that deleting tenants could trigger PVC cleaning.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 That could be an unexpected surprise. I'll follow up with k8s folks about it.

And in the meantime add an example for the other update.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pedro confirmed the PVC and PV aren't deleted, because finalizers. But added a note about setting the storage class retain policy to Retain for good measure.

Copy link
Collaborator

@djwfyi djwfyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than clarifying what happens to the persistent volume.

@feorlen feorlen merged commit 33b2882 into main Aug 31, 2023
@feorlen feorlen deleted the DOCS-943-1 branch August 31, 2023 18:05
Copy link
Collaborator

@djwfyi djwfyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants