-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partial updates for Operator v5.0.7 docs #978
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM mod one small nit.
.. mc-cmd:: --dangerous | ||
:optional: | ||
|
||
Safety flag to confirm deletion of the MinIO Operator and all tenants with :mc-cmd:`~kubectl minio delete --force`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I recall correctly, this may also delete the PVC and PV underlying if the PVC retention isn't set to retain
- https://kubernetes.io/docs/concepts/storage/persistent-volumes/#reclaim-policy
Maybe worth warning here and confirming with someone on the K8s team that deleting tenants could trigger PVC cleaning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 That could be an unexpected surprise. I'll follow up with k8s folks about it.
And in the meantime add an example for the other update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pedro confirmed the PVC and PV aren't deleted, because finalizers. But added a note about setting the storage class retain policy to Retain
for good measure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than clarifying what happens to the persistent volume.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The easy bits from #943:
kubectl minio tenant info
now includes tenant secret info (PR #1704)kubectl minio delete
now has a--force
flag (PR #1687)Staged:
http://192.241.195.202:9000/staging/DOCS-943-1/k8s/reference/kubectl-minio-plugin/kubectl-minio-delete.html
http://192.241.195.202:9000/staging/DOCS-943-1/k8s/reference/kubectl-minio-plugin/kubectl-minio-tenant-info.html
http://192.241.195.202:9000/staging/DOCS-943-1/k8s/operations/install-deploy-manage/deploy-minio-tenant.html#persistent-volumes