Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add storageLabels value to tenant chart #2335

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Add storageLabels value to tenant chart #2335

merged 1 commit into from
Oct 15, 2024

Conversation

dezeroku
Copy link
Contributor

There is already storageAnnotations in place, but sometimes it's required to use labels, e.g. configuring PVC backups via longhorn is based on labels.

ramondeklein
ramondeklein approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@ramondeklein ramondeklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ramondeklein ramondeklein self-assigned this Oct 15, 2024
@ramondeklein ramondeklein merged commit b8c9bf4 into minio:master Oct 15, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shtripat shtripat shtripat approved these changes

@ramondeklein ramondeklein ramondeklein approved these changes

@cniackz cniackz Awaiting requested review from cniackz

Assignees

@ramondeklein ramondeklein

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dezeroku @ramondeklein @shtripat