Line editing layered_store #2332
Conversation
| files are the "real" object-store and suffix (those listed in the | ||
| control file), and can delete any other files it finds (which will be | ||
| control file). The main process can delete any other files it finds (which will be | ||
| the partial files the worker was creating). | ||
|
|
||
| If the worker process has just terminated and a crash occurs, then the |
There was a problem hiding this comment.
Li 296 doesn't have a complete sentence. Could you clarify please?
There was a problem hiding this comment.
Hm there's an extra empty line 298 (which needs to be removed) but the sentence continues below. Does the following makes more sense?
If the worker process terminates just before a crash occurs, then either the current
controlfile contains the atomically renamedcontrol.nnnnworker's file, or it has been left untouched by the worker. If it was successfully renamed, then the main process will start operating on the new object-store and suffix file created by the worker (and will delete any residual old version of those files).
There was a problem hiding this comment.
Thank you! I fixed it and (hopefully) clarified two of those sentences. Please ensure they're still accuarte.
| files are the "real" object-store and suffix (those listed in the | ||
| control file), and can delete any other files it finds (which will be | ||
| control file). The main process can delete any other files it finds (which will be | ||
| the partial files the worker was creating). | ||
|
|
||
| If the worker process has just terminated and a crash occurs, then the |
There was a problem hiding this comment.
Hm there's an extra empty line 298 (which needs to be removed) but the sentence continues below. Does the following makes more sense?
If the worker process terminates just before a crash occurs, then either the current
controlfile contains the atomically renamedcontrol.nnnnworker's file, or it has been left untouched by the worker. If it was successfully renamed, then the main process will start operating on the new object-store and suffix file created by the worker (and will delete any residual old version of those files).
Co-authored-by: art-w <art.wendling@gmail.com>
Although this file may no longer be relevant with the Tezos usage, it was in the repo, so I edited it along with the rest.
In several instances, the "pack file" is referred to rather than
irmin-packfile. Should this beirmin-packeach time? Perhaps wouldpackfile be more accurate or is just > pack file < correct?