Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Lwt.Syntax and avoid some >>= fun () patterns #197

Merged
merged 10 commits into from
Oct 16, 2024
Merged

Use Lwt.Syntax and avoid some >>= fun () patterns #197

merged 10 commits into from
Oct 16, 2024

Commits on Oct 15, 2024

  1. Use Lwt.Syntax and avoid some >>= fun () patterns

    @dinosaure @hannesm
    dinosaure authored and hannesm committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    c7d8751 View commit details
    Browse the repository at this point in the history

  2. Rename some generic fn functions to what they explicitly do

    @dinosaure @hannesm
    dinosaure authored and hannesm committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    98506f5 View commit details
    Browse the repository at this point in the history

  3. Use List.hd instead of [@warning "-8"]

    @dinosaure @hannesm
    dinosaure authored and hannesm committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    e179ee3 View commit details
    Browse the repository at this point in the history

  4. Break the line before the 'in' for a multi-line 'let ... in'

    @dinosaure @hannesm
    dinosaure authored and hannesm committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    ad1afe9 View commit details
    Browse the repository at this point in the history

  5. Add a comment about our usage of List.hd (which can fail) and String.… 

    …split_on_char
    @dinosaure @hannesm
    dinosaure authored and hannesm committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    3dc5456 View commit details
    Browse the repository at this point in the history

  6. Use Ipaddr.V4.Map instead of our own IpMap (the first is available si… 

    …nce ipaddr.5.2.0)
    @dinosaure @hannesm
    dinosaure authored and hannesm committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    a7cb153 View commit details
    Browse the repository at this point in the history

  7. Replace the Lwt.async into the right context and localize the global … 

    …clients map

We currently try to spawn 2 fibers [qubes_updated] and [listener] per clients
and we already finalise them correctly if the client is disconnected. However,
the Lwt.async is localized into add_client instead of where we attach a
finalisers for these tasks. The first objective of this patch is to be sure that
the Lwt.async is near where we registerd cancellation of these tasks.

The second part is to localize the global clients to avoid the ability to
read/write on it somewhere else. Only Dispatcher.watch_clients uses it - so it
corresponds to a free variable of the Dispatcher.watch_clients closure.
    @dinosaure @hannesm
    dinosaure authored and hannesm committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    12ed2b2 View commit details
    Browse the repository at this point in the history

  8. cleanup whitespace

    @hannesm
    hannesm committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    9156d58 View commit details
    Browse the repository at this point in the history

  9. minor: reword XXX to NOTE

    @hannesm
    hannesm committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    ceb712e View commit details
    Browse the repository at this point in the history

  10. update checksum

    @hannesm
    hannesm committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    1406855 View commit details
    Browse the repository at this point in the history