feat(nimbus): Update to mozilla-nimbus-schemas 2024.11.5 #11746
Merged
+34
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brennie
requested review from
jaredlockhart and
yashikakhurana
as code owners
jaredlockhart
requested changes
Nov 12, 2024
experimenter/experimenter/experiments/tests/api/v8/test_serializers.py
Outdated
Show resolved
Hide resolved
brennie
force-pushed
the
beth/schemas/update-experimenter-2024.11.4
branch
2 times, most recently
from
e5bfd2b
to
f7c1119
Compare
brennie
changed the title
experimenter/experimenter/experiments/tests/api/v8/test_serializers.py
Outdated
Show resolved
Hide resolved
Because: - we now have strict and lax schemas for Desktop Nimbus Experiments and a separate schema for SDK Nimbus Experiments in mozilla-nimbus-schemas v2024.11.4; and - the updated Desktop schema now has the correct feature placeholder feature ID This commit: - updates us to mozilla-nimbus-schemas v2024.11.5; and - updates our tests to use the appropriate schema validators in tests Fixes #11745
brennie
force-pushed
the
beth/schemas/update-experimenter-2024.11.4
branch
from
f7c1119
to
74440db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because:
This commit:
Fixes #11745