Obfuscate password length in account dialog (fixes dino#797)

mxlgv · Apr 24, 2024 · 2096cd1 · 2096cd1
1 parent 7555c8e
commit 2096cd1
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/main/src/ui/manage_accounts/dialog.vala b/main/src/ui/manage_accounts/dialog.vala
@@ -45,10 +45,8 @@ public class Dialog : Gtk.Dialog {
         image_button.clicked.connect(show_select_avatar);
         alias_hybrid.entry.changed.connect(() => { selected_account.alias = alias_hybrid.text; });
         password_hybrid.entry.changed.connect(() => {
-            string? pw_buffer;
-            pw_buffer = password_hybrid.text;
-            if (pw_buffer != null && pw_buffer.length > 0 && pw_buffer != "************") {
-              selected_account.password = pw_buffer;
+            if (password_hybrid.text != "************") {
+                selected_account.password = password_hybrid.text;
             }
         });
 
@@ -73,6 +71,7 @@ public class Dialog : Gtk.Dialog {
 
             settings_list.attach(widget, 1, row_index, 2);
             row_index++;
+            password_hybrid.text = "************";
         }
     }
 
@@ -205,7 +204,7 @@ public class Dialog : Gtk.Dialog {
 
         alias_hybrid.text = account.alias ?? "";
         password_hybrid.entry.input_purpose = InputPurpose.PASSWORD;
-        password_hybrid.text = account.password;
+
 
         update_status_label(account);