Retry failed file receipts & extra checks #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows the user to click on a failed file receipt and retry the file download. There are also now checks for if a file marked as complete doesn't exist.
|
@Alphastaire It really works, but a 1MB file on Windows seems to take forever to download. It's probably related to this: #95 |
Yeah, I am unsure what is causing that issue as I haven't done enough debugging, but it's very problematic to say the least. It also happens on Linux with the upstream project. My friend who encountered the issue upstream is not using these commits, so I'm assuming it's a deeply ingrained flaw that will be a pain to deal with. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the user to click on a failed file receipt and retry the file download (from dino#1210).
There are also now checks for if a file marked as complete doesn't exist, which solves #89.