Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NC-4886 Update NamiCampaignManager.refresh #317

Merged
merged 6 commits into from
Sep 5, 2024
Merged

NC-4886 Update NamiCampaignManager.refresh #317

merged 6 commits into from
Sep 5, 2024

Conversation

cp-sumi-k
Copy link
Contributor

@cp-sumi-k cp-sumi-k commented Jun 21, 2024 •
edited
Loading

  • Update the NamiCampaignManager.refresh method to promise-based in native modules (android, iOS)
  • Update examples

@cp-sumi-k cp-sumi-k marked this pull request as draft June 21, 2024 12:33
@cp-sumi-k cp-sumi-k force-pushed the NC-4886-update-nami-campaign-manager-refresh-for-react-native-nami-sdk branch from 1527811 to 0da1ac8 Compare July 3, 2024 07:17
@cp-sumi-k cp-sumi-k marked this pull request as ready for review July 3, 2024 07:20
@cp-sumi-k cp-sumi-k requested review from namidan and joshvermaire and removed request for namidan July 3, 2024 07:20
@namidan namidan merged commit ad96c01 into main Sep 5, 2024
6 of 7 checks passed
@namidan namidan deleted the NC-4886-update-nami-campaign-manager-refresh-for-react-native-nami-sdk branch September 5, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namidan namidan namidan approved these changes

@joshvermaire joshvermaire Awaiting requested review from joshvermaire

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cp-sumi-k @namidan