Added support for multiple-point searches #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankinspace
requested changes
Aug 13, 2024
chuckwondo
requested changes
Aug 13, 2024
There was a problem hiding this comment.
In addition to my code comments, I will repeat @frankinspace's request for you to also include unit tests, which should generally be done as a matter of practice.
chuckwondo
requested changes
Aug 14, 2024
There was a problem hiding this comment.
Thanks @Sherwin-14. Looks good. Just 1 request for slight change to the changelog entry.
|
@Sherwin-14, looks like there's another unit test that needs to be adjusted to pass, like the change made to |
chuckwondo
approved these changes
Aug 15, 2024
|
@frankinspace, are you ready to approve the changes now? |
frankinspace
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came up with a naive solution for the issue #72