Maximize FOV on video call #2297
Draft
+454
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyScherzinger
added
enhancement
|
I don't saw this before writing my comment . I'll a look next week. |
AndyScherzinger
changed the title
I also liked to have it. But as I wrote in the corresponding issue #2052 (comment) the is work to do. |
ASerbinski
force-pushed
the
feature/2052/video-fov
branch
from
5e39e04
to
86a0d5d
Compare
|
There is a bug that causes the preview to be cropped to the screen ratio rather than showing the full preview, introduced in this commit; 892ffe8 ... added fix for this to PR by changing the preview size to 4:3 ratio in dimens.xml |
ASerbinski
force-pushed
the
feature/2052/video-fov
branch
from
86a0d5d
to
58d1de9
Compare
|
Hey all! Any updates on this?. |
1) Use 4:3 video aspect ratio to prevent cropping to 16:9 2) Disable EIS 3) Zoom out
ASerbinski
force-pushed
the
feature/2052/video-fov
branch
from
58d1de9
to
35a403e
Compare
CodacyLint
SpotBugs
Lint increased!SpotBugs increased!org.jetbrains.annotations.NotNull is used. Please use androidx.annotation.NonNull instead. |
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/2297-talk.apk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The field of view on video calls is very narrow, resulting in a transmitted video that is highly "zoomed in".
This increases the field of view using three approaches;
The aspect ratio will affect devices universally, since as far as I can tell, all camera sensors seem to have a 4:3 native aspect ratio. The other two will apply on a sensor by sensor basis. Some phones have a mixture of available zoom ratios, and support for EIS or OIS (where OIS is available, EIS is disabled).
Naturally, there will be tradeoffs for each of the three causes of cropping;
User may have a preference for a 16:9 ratio.
Holding the device in user's hand will result in a jittery video without stabilization.
Changing the zoom ratio could cause the HAL to select a different sensor with different characteristics, for example, the main camera on a Pixel 6 [/Pro] has OIS, but reducing the zoom level to lower than 1:1 will cause it to switch to the wide angle lens, which does not have OIS.
Consequently, it may be preferable for each of these configuration changes to be user-controlled.
Access to the camera on talk-android is through webrtc, which unfortunately, does not provide means of user control for EIS or zoom ratio, however, others have coerced it into allowing settings; https://stackoverflow.com/questions/48598752/android-how-to-turn-on-flashlight-using-webrtc-android-io-pristine-libjingle1
Unfortunately, this approach is a little bit hacky since it requires duplication of some of webrtc.