Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up fixes for the Waveform SeekBar #3234

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

rapterjet2004
Copy link
Contributor

@rapterjet2004 rapterjet2004 commented Aug 2, 2023

Fixes this

  • Larger Bar gap
  • Centered time below play/pause button
  • Time is the same color as the play/pause button

Unfortunately, I wasn't able to fix the play time size. It's puzzling as on paper they should be equal
image
I believe that there is some underlying logic morphing the timestamp in fun showReactions located in the com.nextcloud.talk.adapters.messages.Reaction, but I didn't want to mess with it.


I did some refactoring, so now the number of bars is calculated based off the width of the SeekBar itself. And by extension, the bar gap should also be calculated based off the width of the SeekBar, therefore no matter the size, it should always maintain a good ratio.

Before

follow-up-waveform-seekbar-fixes-before.webm

After

follow-up-waveform-seekbar-fixes-after.webm

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@rapterjet2004 rapterjet2004 self-assigned this Aug 2, 2023
@rapterjet2004 rapterjet2004 added 3. to review Waiting for reviews bug Something isn't working labels Aug 2, 2023
@AndyScherzinger AndyScherzinger added this to the 17.1.0 milestone Aug 2, 2023
- Larger Bar gap
- Centered time below play/pause button
- Time is the same color as the play/pause button

Signed-off-by: Julius Linus <julius.linus@nextcloud.com>
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look better on my high-res device 👍

@rapterjet2004 rapterjet2004 force-pushed the waveform-seekbar-followup-bug-fix branch from 0fce2b8 to 1af04d2 Compare August 2, 2023 19:15
@AndyScherzinger
Copy link
Member

Just give you an idea what I was aiming for (more or less)

Talk with this PR instagramm
Screenshot_20230802_211525 Screenshot_20230802_211606

In a way something between the original code and this PR might be the sweet spot and close to insta. Not saying you should spend that time, just in case you want to :)

@AndyScherzinger
Copy link
Member

So feel free to merge @rapterjet2004 (or I can since the analysis check is failing (in general, everywhere))

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3234-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Codacy

Lint

TypemasterPR
Warnings9394
Errors00

SpotBugs

CategoryBaseNew
Dodgy code118118
Internationalization55
Malicious code vulnerability33
Performance11
Total127127

Lint increased!

@AndyScherzinger AndyScherzinger merged commit 52be519 into master Aug 2, 2023
13 of 14 checks passed
@delete-merged-branch delete-merged-branch bot deleted the waveform-seekbar-followup-bug-fix branch August 2, 2023 19:35
Copy link
Contributor

github-actions bot commented Apr 3, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feedback-requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants