Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add developer docs #4065

Merged
merged 21 commits into from
Sep 17, 2023
Merged

Add developer docs #4065

merged 21 commits into from
Sep 17, 2023

Conversation

bentsherman
Copy link
Member

@bentsherman bentsherman commented Jun 30, 2023

  • Add the developer docs I wrote with class diagrams
  • Add section headers to the docs navbar
  • Add the Nextflow green to navbar

TODO:

  • Add pages for remaining class diagrams

Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
@netlify
Copy link

netlify bot commented Jun 30, 2023

Deploy Preview for nextflow-docs-staging ready!

Name Link
🔨 Latest commit 307d747
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/650737643ef2b30008d2f6d3
😎 Deploy Preview https://deploy-preview-4065--nextflow-docs-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bentsherman
Copy link
Member Author

Look at that beautiful preview! 😄

@bentsherman bentsherman marked this pull request as ready for review June 30, 2023 17:26
bentsherman and others added 2 commits June 30, 2023 12:27
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
@bentsherman
Copy link
Member Author

@pditommaso can we merge this one

@marcodelapierre
Copy link
Member

I am keen to provide an external review on the dev docs, will be on it next Monday.

@marcodelapierre
Copy link
Member

marcodelapierre commented Aug 28, 2023

Hi @bentsherman @pditommaso , here some comments/suggestions, from a contents perspective:

Navigation bar

  • I LOVE the classification of the sections!
  • I suggest moving "Plugins" from "Execution" to "Additional software"

Section Contributing -> Overview

  • All links tested OK
  • Class Diagrams: I suggest adding a link to the Packages section
  • Building and Testing: isn't Gradle also a requirement for building?

Section Contributing -> Packages

  • I haven't read everything, mostly flied over the introductory statement and the diagram
  • nextflow: Nextflow and Channel still work in progress? any minimal info that can be inserted?
  • nextflow.ast: please define/explain concisely "AST"
  • nextflow.cache: could these (and any other type of) arrows be introduced in the main Packages page?

Hope this helps to get closer to merge ;)

@bentsherman
Copy link
Member Author

That's weird, I just opened the cache page in the deploy preview and the diagram works 🤷‍♂️

@ewels
Copy link
Member

ewels commented Aug 29, 2023

Are we talking about this? In which case yeah, works fine for me too..

CleanShot 2023-08-29 at 15 45 16@2x

Signed-off-by: Ben Sherman <bentshermann@gmail.com>
@marcodelapierre
Copy link
Member

I can see that one fine, too, I mean the Class Diagram section (not page, sorry) inside the Overview page, docs/_build/html/developer/index.html in the built docs.

See screenshot below:

Screenshot 2023-08-30 at 10 03 08 am

Signed-off-by: Ben Sherman <bentshermann@gmail.com>
@bentsherman
Copy link
Member Author

I see, well, I don't want to put a whole mermaid diagram there just to show the arrows, but I can put the equivalent code which should give some hint. They are basically the conventions used by Mermaid diagrams: https://mermaid.js.org/syntax/classDiagram.html#defining-relationship

@ewels
Copy link
Member

ewels commented Aug 31, 2023

Nice, preview here: https://deploy-preview-4065--nextflow-docs-staging.netlify.app/developer/index.html#class-diagrams

Note

@marcodelapierre note that the deployment preview mentioned in a comment further up continuously updates whenever a new commit is pushed, so you can just look at that rather than needing to build locally...

@marcodelapierre
Copy link
Member

I see, well, I don't want to put a whole mermaid diagram there just to show the arrows, but I can put the equivalent code which should give some hint. They are basically the conventions used by Mermaid diagrams: https://mermaid.js.org/syntax/classDiagram.html#defining-relationship

Completely agree, a legend would do in my opinion

@marcodelapierre
Copy link
Member

marcodelapierre commented Sep 1, 2023

ah damn! Sorry @bentsherman , my finger slipped on the trackpad! reopening now

@marcodelapierre
Copy link
Member

marcodelapierre commented Sep 1, 2023

Nice, preview here: https://deploy-preview-4065--nextflow-docs-staging.netlify.app/developer/index.html#class-diagrams

Note @marcodelapierre note that the deployment preview mentioned in a comment further up continuously updates whenever a new commit is pushed, so you can just look at that rather than needing to build locally...

thanks Phil, hadn't noticed the preview feature! -- rather than rebuilding myself, I think I would had rather lazily asked Ben for a snapshot 🤣

@ewels
Copy link
Member

ewels commented Sep 1, 2023

@marcodelapierre - I discovered website deployment previews on PRs rather recently, and now I can't live without them; adding them to every repository I can 😆

@marcodelapierre
Copy link
Member

I tooootally understand, from now on I won't live without them neither!!

@pditommaso
Copy link
Member

@ewels
Copy link
Member

ewels commented Sep 1, 2023

@pditommaso don't make me 😢 Surely this is negated by me stripping out unnecessary CI checks? 😉

(I was about to argue that I would spend the CPU cycles building locally anyway, but I guess you're right that the web server is running constantly for us to have them).

@marcodelapierre
Copy link
Member

ah, good point Paolo!

Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
@pditommaso
Copy link
Member

Ok, nice. I made a few changes in the TOC. Nice job!

@pditommaso pditommaso merged commit 06843d8 into master Sep 17, 2023
5 checks passed
@pditommaso pditommaso deleted the ben-developer-docs branch September 17, 2023 17:29
@mribeirodantas
Copy link
Member

🤩 So happy that this PR has been merged! Way to go, guys!

@marcodelapierre
Copy link
Member

Love this, love the refreshed docs look! Great initiative @bentsherman! 🤩

@ewels
Copy link
Member

ewels commented Sep 18, 2023

abhi18av pushed a commit to abhi18av/nextflow that referenced this pull request Oct 28, 2023

Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Co-authored-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants