-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add developer docs #4065
Add developer docs #4065
Conversation
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Look at that beautiful preview! 😄 |
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
@pditommaso can we merge this one |
81f7cb7
to
8a43489
Compare
I am keen to provide an external review on the dev docs, will be on it next Monday. |
Hi @bentsherman @pditommaso , here some comments/suggestions, from a contents perspective: Navigation bar
Section Contributing -> Overview
Section Contributing -> Packages
Hope this helps to get closer to merge ;) |
That's weird, I just opened the cache page in the deploy preview and the diagram works 🤷♂️ |
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
I see, well, I don't want to put a whole mermaid diagram there just to show the arrows, but I can put the equivalent code which should give some hint. They are basically the conventions used by Mermaid diagrams: https://mermaid.js.org/syntax/classDiagram.html#defining-relationship |
Nice, preview here: https://deploy-preview-4065--nextflow-docs-staging.netlify.app/developer/index.html#class-diagrams Note @marcodelapierre note that the deployment preview mentioned in a comment further up continuously updates whenever a new commit is pushed, so you can just look at that rather than needing to build locally... |
Completely agree, a legend would do in my opinion |
ah damn! Sorry @bentsherman , my finger slipped on the trackpad! reopening now |
thanks Phil, hadn't noticed the preview feature! -- rather than rebuilding myself, I think I would had rather lazily asked Ben for a snapshot 🤣 |
@marcodelapierre - I discovered website deployment previews on PRs rather recently, and now I can't live without them; adding them to every repository I can 😆 |
I tooootally understand, from now on I won't live without them neither!! |
@pditommaso don't make me 😢 Surely this is negated by me stripping out unnecessary CI checks? 😉 (I was about to argue that I would spend the CPU cycles building locally anyway, but I guess you're right that the web server is running constantly for us to have them). |
ah, good point Paolo! |
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Ok, nice. I made a few changes in the TOC. Nice job! |
🤩 So happy that this PR has been merged! Way to go, guys! |
Love this, love the refreshed docs look! Great initiative @bentsherman! 🤩 |
Signed-off-by: Ben Sherman <bentshermann@gmail.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Co-authored-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
TODO: