Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperqueue breaking change (memory request) #4884

Closed
wants to merge 1 commit into from

Conversation

njspix
Copy link
Contributor

@njspix njspix commented Apr 4, 2024

Hyperqueue version ≥ 0.17 needs memory requested in megabytes, not bytes.
(https://github.com/It4innovations/hyperqueue/blob/main/CHANGELOG.md#breaking-change-1)
Worth adding a hyperqueue version check somehow??

Hyperqueue version 0.17 needs memory requested in megabytes, not bytes

Signed-off-by: Nathan Spix <56930974+njspix@users.noreply.github.com>
Copy link

netlify bot commented Apr 4, 2024

Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit ffda50f
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/660f0fcd2d480a0008ddca4f

@pditommaso
Copy link
Member

It's a bit ugly. Is there no way to keep backward compatibility ?

@njspix
Copy link
Contributor Author

njspix commented Apr 5, 2024

I agree. Hyperqueue (and its support in nextflow) is still in beta, I think, so breaking changes are not unexpected, but agree would like to avoid if all possible.
Currently it raises a job submission error. Do you think it would be feasible to check the content of the error (I think it's pretty specific, something like "couldn't coerce requested memory to type xzy") and then submit all remaining jobs with the memory in mb?

Or maybe it's simpler to just run a shell hq --version and check the output?

@pditommaso
Copy link
Member

I'd avoid adding extra logic to check the error or the version. Worth adding a note in documentation on the minimal version of HyperQueue expected.

Also note there are some failing tests

@pditommaso pditommaso marked this pull request as draft April 10, 2024 16:06
@njspix njspix closed this May 6, 2024
@njspix
Copy link
Contributor Author

njspix commented May 6, 2024

Closing for now, not urgent. Thanks!

@pditommaso
Copy link
Member

Merged manually via b45f7c4

@pditommaso pditommaso closed this Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants