Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation about azcopy installation requirements for custom Azure Batch worker pools #4911

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

adamrtalbot
Copy link
Collaborator

@adamrtalbot adamrtalbot commented Apr 12, 2024

The Azure documentation was missing the requirement to install azcopy on each worker pool. This caused some confusion on the community Slack so I decided to update the docs to make it clear that azcopy is required.

Signed-off-by: Adam Talbot 12817534+adamrtalbot@users.noreply.github.com

Hi! Thanks for contributing to Nextflow project.

When submitting a Pull Request please make sure to not include
in the changeset any modification in these files:

  • nextflow
  • modules/nf-commons/src/main/nextflow/Const.groovy

Also, please sign-off the DCO [1] to certify you are the author of the contribution
and you adhere to Nextflow open source license [2] adding a Signed-off-by line to
the contribution commit message. For more details check [3].

  1. https://developercertificate.org/
  2. https://github.com/nextflow-io/nextflow/blob/master/COPYING
  3. https://github.com/apps/dco

…om Azure Batch worker pools

Signed-off-by: Adam Talbot <12817534+adamrtalbot@users.noreply.github.com>
@adamrtalbot adamrtalbot requested a review from a team as a code owner April 12, 2024 08:34
Copy link

netlify bot commented Apr 12, 2024

Deploy Preview for nextflow-docs-staging ready!

Name Link
🔨 Latest commit d8c32fc
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/6618fba363772300086d46b8
😎 Deploy Preview https://deploy-preview-4911--nextflow-docs-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Adam Talbot <12817534+adamrtalbot@users.noreply.github.com>
@pditommaso
Copy link
Member

Hold on, the azcopy is installed as a resource automatically by this

resourceFiles << new ResourceFile()
.withHttpUrl(AZCOPY_URL)
.withFilePath('azcopy')

@adamrtalbot
Copy link
Collaborator Author

Hold on, the azcopy is installed as a resource automatically by this

resourceFiles << new ResourceFile()
.withHttpUrl(AZCOPY_URL)
.withFilePath('azcopy')

That code snippet refers to when Nextflow creates the pool. This refers to manually pointing at an existing Azure Pool (i.e. using process.queue).

@pditommaso
Copy link
Member

Ok!

@pditommaso pditommaso merged commit 5c410db into nextflow-io:master Apr 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants