Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix isContainerReady when wave is disabled #5509

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

pditommaso
Copy link
Member

This PR fixes the access to the method isContainerReady when Wave is disabled.

Solve #5503

Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit 803f4ee
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/67363e03acdbe2000867cd1a

@pditommaso
Copy link
Member Author

@jordeu likely you have already the test script and container in place, can you please validate it ?

Copy link
Collaborator

@jordeu jordeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and now it works as expected

@pditommaso
Copy link
Member Author

Thanks!

@pditommaso pditommaso merged commit 3215afa into master Nov 18, 2024
21 checks passed
@pditommaso pditommaso deleted the fix-wave-disable-ready-check branch November 18, 2024 08:15
pditommaso added a commit that referenced this pull request Nov 18, 2024
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants