Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release candidate 1.4.1 #177

Merged
merged 28 commits into from
Feb 27, 2024
Merged

Release candidate 1.4.1 #177

merged 28 commits into from
Feb 27, 2024

Conversation

Aratz
Copy link
Contributor

@Aratz Aratz commented Feb 27, 2024

Solves #175

Includes the following:

Changed

  • #167 Updated template to nf-core/tools v2.12
  • #163 Updated template to nf-core/tools v2.11.1
  • #162 Updated template to nf-core/tools v2.11

Aratz and others added 26 commits December 15, 2023 08:44
Bump version to 1.5.0dev
Important! Template update for nf-core/tools v2.11
Important! Template update for nf-core/tools v2.11.1
Ran `nf-core modules update`
Important! Template update for nf-core/tools v2.12
chore: emiller88 => edmundmiller
This is done to solve #175 in a timely fashion. This commit should be
reverted after the release is done.
@Aratz Aratz requested review from nh13, sam-white04, blajoie and a team as code owners February 27, 2024 11:34
Copy link

github-actions bot commented Feb 27, 2024

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit ef60565

+| ✅ 166 tests passed       |+
#| ❔   3 tests were ignored |#
!| ❗   5 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 1.4.1
  • pipeline_todos - TODO string in README.md: Describe the minimum required steps to execute the pipeline, e.g. how to prepare samplesheets.
  • pipeline_todos - TODO string in WorkflowDemultiplex.groovy: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.12.1
  • Run at 2024-02-27 14:44:56

@@ -1,9 +1,9 @@
{
"software_versions": {
"content": [
"{BASES2FASTQ={bases2fastq=1.1.0.593880262, use subject to license available at elementbiosciences.com}, CUSTOM_DUMPSOFTWAREVERSIONS={python=3.12.0, yaml=6.0.1}, FALCO={falco=1.2.1}, FASTP={fastp=0.23.4}, UNTAR={untar=1.30}, Workflow={nf-core/demultiplex=1.4.0}}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the version downgrades?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, this is the result of the last update of CUSTOM_DUMPSOFTWAREVERSIONS in #167 (see also nf-core/tools@93f6af8). I suspect it's linked to the MultiQC upgrade from 1.17 to 1.19, but all I could find was https://github.com/MultiQC/MultiQC/blob/19cec5cd5c967fc6a660cd7a354a11d5cff3dfbf/.github/RELEASE_CHECKLIST.md?plain=1#L29

Maybe @ewels or @mashehu know more about this.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related, why no MultiQC 1.20?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question 😁 It made the tests fail in #176. For the sake of making this new release asap and because I'm a bit tight on time this week, I decided to keep it at 1.19 for now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the downgrade of python? We ran into some errors with 3.12, so recommend 3.11 at the moment

Copy link
Collaborator

@matthdsm matthdsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment out of curiosity, LGTM otherwise

Copy link
Collaborator

@edmundmiller edmundmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Agreed that MultiQC 1.20 can be a future release.

@Aratz
Copy link
Contributor Author

Aratz commented Feb 27, 2024

Thanks! I might need some help with merging this PR, GitHub says it's out of date with the base branch, but when I click "Update branch", I get the following error message: Changes must be made through a pull request..

Probably needs help overriding the nf-core download test too 😬

CHANGELOG.md Outdated Show resolved Hide resolved
@Aratz Aratz merged commit aa4d936 into master Feb 27, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants