-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release candidate 1.4.1 #177
Conversation
Bump version to 1.5.0dev
Important! Template update for nf-core/tools v2.11
Important! Template update for nf-core/tools v2.11.1
Ran `nf-core modules update`
Important! Template update for nf-core/tools v2.12
Fix badges
chore: emiller88 => edmundmiller
Solves #175
This is done to solve #175 in a timely fashion. This commit should be reverted after the release is done.
Pre-release v1.4.1
|
@@ -1,9 +1,9 @@ | |||
{ | |||
"software_versions": { | |||
"content": [ | |||
"{BASES2FASTQ={bases2fastq=1.1.0.593880262, use subject to license available at elementbiosciences.com}, CUSTOM_DUMPSOFTWAREVERSIONS={python=3.12.0, yaml=6.0.1}, FALCO={falco=1.2.1}, FASTP={fastp=0.23.4}, UNTAR={untar=1.30}, Workflow={nf-core/demultiplex=1.4.0}}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the version downgrades?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, this is the result of the last update of CUSTOM_DUMPSOFTWAREVERSIONS
in #167 (see also nf-core/tools@93f6af8). I suspect it's linked to the MultiQC upgrade from 1.17 to 1.19, but all I could find was https://github.com/MultiQC/MultiQC/blob/19cec5cd5c967fc6a660cd7a354a11d5cff3dfbf/.github/RELEASE_CHECKLIST.md?plain=1#L29
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related, why no MultiQC 1.20?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question 😁 It made the tests fail in #176. For the sake of making this new release asap and because I'm a bit tight on time this week, I decided to keep it at 1.19 for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the downgrade of python? We ran into some errors with 3.12, so recommend 3.11 at the moment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment out of curiosity, LGTM otherwise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Agreed that MultiQC 1.20 can be a future release.
Thanks! I might need some help with merging this PR, GitHub says it's out of date with the base branch, but when I click "Update branch", I get the following error message: Probably needs help overriding the nf-core download test too 😬 |
Solves #175
Includes the following:
Changed