Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update checkqc #231

Merged
merged 4 commits into from
Aug 8, 2024
Merged

update checkqc #231

merged 4 commits into from
Aug 8, 2024

Conversation

atrigila
Copy link
Contributor

@atrigila atrigila commented Aug 8, 2024 •
edited
Loading

Fixes: #228

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/demultiplex branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@atrigila atrigila self-assigned this Aug 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 468883b

+| ✅ 190 tests passed       |+
#| ❔   3 tests were ignored |#
!| ❗   6 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in README.md: Describe the minimum required steps to execute the pipeline, e.g. how to prepare samplesheets.
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-08-08 12:52:17

@atrigila atrigila requested a review from grst August 8, 2024 12:45
@atrigila atrigila marked this pull request as ready for review August 8, 2024 13:25
@atrigila atrigila requested a review from a team as a code owner August 8, 2024 13:25
@atrigila atrigila requested review from matthdsm and removed request for a team August 8, 2024 13:25
@atrigila atrigila linked an issue Aug 8, 2024 that may be closed by this pull request
CheckQC fails for unclear reason #228
Closed
grst
grst approved these changes Aug 8, 2024
View reviewed changes
Copy link
Member

@grst grst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atrigila atrigila merged commit e3d6e94 into nf-core:dev Aug 8, 2024
12 checks passed
@grst grst mentioned this pull request Aug 12, 2024
Closed
@apeltzer apeltzer mentioned this pull request Aug 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grst grst grst approved these changes

@matthdsm matthdsm Awaiting requested review from matthdsm matthdsm is a code owner automatically assigned from nf-core/demultiplex

Assignees

@atrigila atrigila

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CheckQC fails for unclear reason
2 participants
@atrigila @grst