Skip to content

Commit

Permalink
Updating niscope enums (#620)
Browse files Browse the repository at this point in the history
* adding some of missing enums for niscope
* Attaching enums to methods
* updating generated niscope files
* fixed review comments
* updating generated files for niscope
* fixed niscope systemtests to have proper enums
* adding enum for sendSoftwareTriggerEdge
* updating generated for niscope
* added comment back on functions_addon.py to update enums
* updating inputImpedance enum to have proper value
* Updating generated for niscope
* updating enums_addon.py to have niscope enums
* adding new enums to enums_addon.py
* updpating AcquisitionStatus to have proper values
* updating generated for niscope
* updating niscope system test to check acquisition_status retunrs enum
* Adding attribute tests for niscope
* Fixing Flake8 Failure
* Updating channel enums to be strings. Updating names of channel enums to be consistent with C 
 enums. Adding all enums for trigger source in .h file.
* Adding missed enums on functions_addon.py
* Removed redundant enum form functions_addon for niscope
* updating enums_addon for niscope to have names starts with NISCOPE_VAL_
* updating generated for niscope
* Removing TriggerSource, TriggerSourceDigital, and ExportDestinations enums that are strings
* Adding .eggs to exlude line
* Making system tests use defaults
* Fixing space
  • Loading branch information
injaleea authored and texasaggie97-zz committed Nov 27, 2017
1 parent e9aea94 commit a722d9b
Show file tree
Hide file tree
Showing 8 changed files with 1,607 additions and 141 deletions.
18 changes: 0 additions & 18 deletions NI-SCOPE review notes.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,24 +2,6 @@

Everything listed here still needs to be implemented.

##Enums

* add_waveform_processing should have enum
* cal_self_calibrate needs enum
* clear_waveform_measurement_stats needs enum
* configure_vertical coupling is enum
* fetch_measurement scalar_meas_function
* fetch_measurement_stats scalar_meas_function
* read_measurement scalar_meas_function
* acquisition_status return enum
* configure_trigger_digital slope
* configure_trigger_edge slope, trigger_coupling
* configure_trigger_hysteresis(self, trigger_source, level, hysteresis, slope, trigger_coupling, holdoff, delay):
* configure_trigger_video signal_format, event, polarity, trigger_coupling
* configure_trigger_window window_mode, trigger_coupling
* export_signal signal
* send_software_trigger_edge which_trigger

##Other notes

* The following still need review. PR to support them has been merged.
Expand Down
Loading

0 comments on commit a722d9b

Please sign in to comment.