-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Night mode #2840
base: dev
Are you sure you want to change the base?
[WIP] Night mode #2840
Conversation
A welcome change. I've solved exactly this myself with automations. But this will make it easier to keep nights steady for users having trouble configuring automations. |
plugins/aps/src/main/java/info/nightscout/plugins/aps/openAPSSMB/OpenAPSSMBPlugin.kt
Outdated
Show resolved
Hide resolved
Making the same with automations not only is WAY more complex and lies beyond most user's expertise, but also depends on other settings that can be unwanted during the rest of the day, but cannot be changed with automations. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
I love the idea of being able to disable SMB at night. However I think this adds too much settings, and also the placement of the settings is not logical to me. I suggest the following:
Make "enable SMB with COB" and "SMB with TT" also work outside the timewindow. do not add a setting for this, but maybe clarify that it will override the timewindow This will make it more in line with the current settings for SMB we have. Additionally you could group all SMB related settings in a sub menu of openAPS SMB Also a setting like BG offset is not obvious to many users.. With what I propose the same can be achieved by an automation (setting a low TT when BG is above a certain offset) |
These settings apply to SMB and Dynamic ISF SMB (and also to other plugins like EN/Boost/AutoISF/AIMI...) - thats why I placed these to
Automations are much less obvious - this is an attempt to keep this as a restriction policy, confgured in one place for all of the plugins. The safety one. Without automations, tricky SMB plugin combinations etc. |
Basically a very good point, IMHO many would need an SMB_off option - maybe not only at night. There is another existing solution in autoISF based on even/odd temptarget (odd means SMB_off). But the most straightforward and versatile would be an additional automation action to disable SMB. |
Totally unusable for |
If using mmol/L the decimal is considered by autoISF. |
This PR adds overnight SMB restriction mode (inspired by Eating Now @dicko72).
So during night while your BG is below
profileTarget
+BG offset
- SMB will be disabled and only TBR will be active for plugins.When BG escalates higher than
profileTarget
+BG offset
- SMB overnight restriction falls off.You can also set up Night mode to be disabled if COB > 0.
Or when Temp Target is set lower than profile target.
07..15:00 time is set here because I were testing it during a day now :)
The idea of this mode itself is to add some security mode against overnight sensor pressures. Here is my daughter's BG this night - these fast drops are sensor pressures, and quick rises - BG comes back to real after pressure released.
Usually AAPS acts like this for these quick rises (see many SMBs here)
But frankly thats a graph from my test phone connected to virtual pump, because in reality MUCH lower amount of insulin were required to deal with that:
TBS is way more safe for such beaviour