Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open aps show proper debug log #3238

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

jbr7rr
Copy link

@jbr7rr jbr7rr commented Feb 24, 2024

Since the Kotlin port of openAPS the debug log in the overview did not show all information anymore. in 3.2 both debug and error log was shown as one in the overview screen.

This pull requests merges the debug log and error log and shows them in the debug screen. error logs are now shown in red. I'm not sure if I like the color red for this, any suggestions are welcome.

Master:

Screenshot_20240224-180834_AAPS

Dev:

Screenshot_20240224-142910_AAPS

PR:

Screenshot_20240224-143904_AAPS

Copy link

sonarcloud bot commented Feb 24, 2024

Quality Gate Passed Quality Gate passed

Issues
117 New issues

Measures
0 Security Hotspots
No data about Coverage
1.4% Duplication on New Code

See analysis details on SonarCloud

@MilosKozak
Copy link
Contributor

is 3.2 there was a error log and debug log. one of it was presented to the user (second one to log only)
I'm not sure (i didn't review it yet) if this is preserved in kotlin conversion but I'd keep it to have the same user experience

@jbr7rr
Copy link
Author

jbr7rr commented Feb 26, 2024

is 3.2 there was a error log and debug log. one of it was presented to the user (second one to log only) I'm not sure (i didn't review it yet) if this is preserved in kotlin conversion but I'd keep it to have the same user experience

I don't exactly how it was in code, but as you can see in my screenshot from master, all information that is in de error log and debug log was presented in the debug screen in the overview.

@ga-zelle
Copy link

I cannot really see a big difference between "log" and "error" type messages here. Their purpose is to provide information about what happened during the loop logic and why.

Especially in 3.3dev even the sequence of events is lost because info is split between "log" and "error".

@jbr7rr
Copy link
Author

jbr7rr commented Apr 25, 2024

I cannot really see a big difference between "log" and "error" type messages here. Their purpose is to provide information about what happened during the loop logic and why.

Especially in 3.3dev even the sequence of events is lost because info is split between "log" and "error".

Yeah, maybe best solution would be to drop one of them and only use debug or error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants