Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.2.1.0 #3262

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

3.2.1.0 #3262

wants to merge 23 commits into from

Conversation

MilosKozak
Copy link
Contributor

No description provided.

@jbr7rr
Copy link

jbr7rr commented Mar 11, 2024

Maybe include #3258 as well? Without pr overviews of mentioned pumps are unreadable in light theme

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 1.74611% with 4164 lines in your changes are missing coverage. Please review.

Project coverage is 20.86%. Comparing base (af45179) to head (74879ed).
Report is 15 commits behind head on master.

Current head 74879ed differs from pull request most recent head 7d73e5d

Please upload reports for the commit 7d73e5d to get more accurate results.

Files Patch % Lines
...java/app/aaps/pump/equil/manager/EquilManager.java 0.00% 600 Missing ⚠️
...c/main/java/app/aaps/pump/equil/EquilPumpPlugin.kt 0.00% 272 Missing ⚠️
.../src/main/java/app/aaps/pump/equil/ble/EquilBLE.kt 0.00% 268 Missing ⚠️
...p/aaps/pump/equil/ui/EquilHistoryRecordActivity.kt 0.00% 257 Missing ⚠️
...ump/equil/ui/pair/EquilPairSerialNumberFragment.kt 0.00% 232 Missing ⚠️
...src/main/java/app/aaps/pump/equil/EquilFragment.kt 0.00% 230 Missing ⚠️
...a/app/aaps/pump/equil/manager/command/BaseCmd.java 0.00% 152 Missing ⚠️
...s/pump/equil/manager/command/CmdDevicesOldGet.java 0.00% 119 Missing ⚠️
...pp/aaps/pump/equil/ui/pair/EquilPairAirFragment.kt 0.00% 95 Missing ⚠️
...a/app/aaps/pump/equil/manager/command/CmdPair.java 0.00% 89 Missing ⚠️
... and 68 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3262      +/-   ##
============================================
- Coverage     21.58%   20.86%   -0.72%     
- Complexity     5002     5019      +17     
============================================
  Files          2345     2421      +76     
  Lines        114752   118979    +4227     
  Branches      15740    16127     +387     
============================================
+ Hits          24765    24827      +62     
- Misses        87817    91977    +4160     
- Partials       2170     2175       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MilosKozak
Copy link
Contributor Author

MilosKozak commented Mar 12, 2024

Maybe include #3258 as well? Without pr overviews of mentioned pumps are unreadable in light theme

The change is there too. It was not possible to cherry-pick from dev because of huge amount of commits affecting the code so I had to copy latest code as a new commit and merge back

Copy link

sonarcloud bot commented Mar 26, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
19 Security Hotspots
5.6% Duplication on New Code (required ≤ 3%)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

MilosKozak and others added 13 commits May 31, 2024 09:37
Bumps com.android.tools.build:gradle from 8.2.1 to 8.2.2.

---
updated-dependencies:
- dependency-name: com.android.tools.build:gradle
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps com.google.gms:google-services from 4.4.0 to 4.4.1.

---
updated-dependencies:
- dependency-name: com.google.gms:google-services
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps com.android.tools.build:gradle from 8.2.2 to 8.3.0.

---
updated-dependencies:
- dependency-name: com.android.tools.build:gradle
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps com.android.tools.build:gradle from 8.3.0 to 8.3.1.

---
updated-dependencies:
- dependency-name: com.android.tools.build:gradle
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps com.android.tools.build:gradle from 8.3.1 to 8.3.2.

---
updated-dependencies:
- dependency-name: com.android.tools.build:gradle
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
This reverts commit 1beb6ea.
Copy link

sonarcloud bot commented May 31, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
19 Security Hotspots
5.5% Duplication on New Code (required ≤ 3%)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link

sonarcloud bot commented Jul 20, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
19 Security Hotspots
5.5% Duplication on New Code (required ≤ 3%)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@olorinmaia
Copy link
Contributor

Consider cherry-picking:
f10ccc8d
9999991b
4d8b87e6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants