Change visibility of Boluswizard and Insulin button in AAPSClient #3374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be similar to that of Carbs button
|
Not sure to understand your proposal (why you keep Insulin button in AAPSClient version 🤔). |
|
AAPSClient is for follower as you know. It is not possible to administer insulin via pump in any scenario. Thus there is no reason to hide the buttons. When we disconnect pod it is useful some times to register insulin given by pen. |
|
I can be wrong (never used AAPSClient myself), but I thought it was possible to send a bolus from AAPSClient to AAPS followed remotly... |
|
You can add a bolus from AAPSClient that count towards iob, but will not be delivered by pump. This warning is always visible and can't be turned off.😉
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can't bolus via pump from AAPSClient, thus it makes no sense to hide Insulin and Boluswizard button in AAPSClient when pump is disconnected from AAPS. This change will make visibility to these buttons to be similar to that of Carbs button.
We disconnect pump in AAPS when our son goes swimming, and it would be useful to check Bolus wizard for missing carbs for example in AAPSClient.