-
Notifications
You must be signed in to change notification settings - Fork 71.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix devicestatus and treatments id delete #4088
Fix devicestatus and treatments id delete #4088
Conversation
(cherry picked from commit c945c2e)
@jpcunningh Do you understand why you need to create a new variable and refer to that in the JSON From reading the code I would assume that the new code is equivalent (but introduces a new temporary variable). Am I missing something? |
Omg stop sending these threads. I hetbloke 50 emails a day. Stop stop stop please |
@candreassen if you get emails from changes in Nigthscout, it means your account is actively "watching" the Nightscout repository and thus will get an email from every change. If you want the email to stop, go to the Github Nightscout page (for example, click the "view in Github" link in the email with this message) and find a button on top of the page that says "Unwatch" and either choose "Not Watching" or "Ignore" from the menu. |
@PieterGit looks like calling the remove() method call with |
Thank you for the explanation, @sulkaharo! I didn't know why one way worked vs. the other. |
@sulkaharo thanks for the explanation. I hate merging stuff I don't understand. |
The user documentation for this feature can be improved. I logged issue nightscout/documentation#2 for that. |
How do I stop getting email notifications
… On Jan 7, 2019, at 1:33 AM, PieterGit ***@***.***> wrote:
The user documentation for this feature can be improved. I logged issue nightscout/documentation#2 for that.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Fix for #4080