Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Require Sphinx greater or equal 7.2 #171

Closed
wants to merge 1 commit into from

Conversation

jhlegarreta
Copy link
Collaborator

Require Sphinx greater or equal 7.2 (released Aug 16, 2023).

Fixes:

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed.
This behaviour is the source of the following dependency conflicts.
sphinx 4.5.0 requires docutils<0.18,>=0.14, but you have docutils 0.21.1 which is incompatible.
sphinx-rtd-theme 1.0.0 requires docutils<0.18, but you have docutils 0.21.1 which is incompatible.

raised for example in:
https://app.circleci.com/pipelines/github/nipreps/eddymotion/978/workflows/62e30eb5-72ed-4cf9-8b47-0172cad51228/jobs/951

Require Sphinx greater or equal 7.2 (released Aug 16, 2023).

Fixes:
```
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed.
This behaviour is the source of the following dependency conflicts.
sphinx 4.5.0 requires docutils<0.18,>=0.14, but you have docutils 0.21.1 which is incompatible.
sphinx-rtd-theme 1.0.0 requires docutils<0.18, but you have docutils 0.21.1 which is incompatible.
```

raised for example in:
https://app.circleci.com/pipelines/github/nipreps/eddymotion/978/workflows/62e30eb5-72ed-4cf9-8b47-0172cad51228/jobs/951
@jhlegarreta
Copy link
Collaborator Author

Untested. None of my PRs has permissions to trigger CircleCI builds, and thus errors cannot be caught early enough:
https://support.circleci.com/hc/en-us/articles/360050273651-Troubleshooting-Builds-Unauthorized-due-to-contexts

@esavary esavary mentioned this pull request Apr 17, 2024
@esavary
Copy link
Member

esavary commented Apr 17, 2024

Untested. None of my PRs has permissions to trigger CircleCI builds, and thus errors cannot be caught early enough: https://support.circleci.com/hc/en-us/articles/360050273651-Troubleshooting-Builds-Unauthorized-due-to-contexts

Hi, my PRs can trigger builds, but it seems I don't have write permissions on CircleCi to trigger yours. @oesteban or @effigies, could you trigger it for testing?

@effigies
Copy link
Member

@jhlegarreta I've invited you with write permissions on this repository. Hopefully Circle will figure it out. I manually triggered this one and got:

https://app.circleci.com/pipelines/github/nipreps/eddymotion/982/workflows/778a2cda-b4a4-418a-b59a-7cde7d3b40e5/jobs/962

INFO: pip is looking at multiple versions of eddymotion to determine which version is compatible with other requirements. This could take a while.
ERROR: Package 'eddymotion' requires a different Python: 3.9.12 not in '>=3.10'

@jhlegarreta
Copy link
Collaborator Author

I've invited you with write permissions on this repository. Hopefully Circle will figure it out. I manually triggered this one and got:

Got that. Thanks Chris.

I manually triggered this one and got:

OK. Not sure why it keeps on looking for 3.9: I first switched to a cimg docker image as the nipreps docker image had the 3.9 label on it, but then Oscar told me that the nipreps docker image was indeed shipping 3.11. So my best guess now is that the docker image we are using is not shipping or using Python >= 3.10.

@effigies
Copy link
Member

Right now we're using nipreps/miniconda:py39_2205.0, which bundles Python 3.9.

For reasons I don't understand, it looks like py39_2403.0 does contain Python 3.11:

docker run --rm -it nipreps/miniconda:py39_2403.0 python --version
Python 3.11.8

@jhlegarreta
Copy link
Collaborator Author

For reasons I don't understand, it looks like py39_2403.0 does contain Python 3.11:

If multiple versions should be shipped, then we should make sure that it is picking Python 3.11, if there is a way to do that.

@oesteban
Copy link
Member

oesteban commented Apr 17, 2024 via email

@effigies
Copy link
Member

If multiple versions should be shipped, then we should make sure that it is picking Python 3.11, if there is a way to do that.

Update the tag in L8 of .circleci/config.yml.

@jhlegarreta
Copy link
Collaborator Author

Update the tag in L8 of .circleci/config.yml.

Which is the tag that should be used?

@effigies
Copy link
Member

py39_2403.0

@jhlegarreta
Copy link
Collaborator Author

py39_2403.0

🤦‍♂️ yes, sorry, Chris: I now realize that your mentioned it. PR #177.

@jhlegarreta
Copy link
Collaborator Author

Closing in favor of #177: looks like that is the right fix.

@jhlegarreta jhlegarreta deleted the BumpSphinx branch April 17, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants