-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add DWI volume plot method #101
Conversation
Test data missing in here: tested with ds000114 from openneuro. Probably too large (104 MB) to add it here. Let me know which other dMRI volume that you know we could use. |
a88f6eb
to
c70e36d
Compare
Add DWI volume plot method.
c70e36d
to
97a286e
Compare
Added a downsampled and truncated copy of the indicated file. 3.5MB, which seems a reasonably modest addition and will be excluded from wheels. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
==========================================
+ Coverage 58.43% 58.45% +0.01%
==========================================
Files 22 22
Lines 2086 2094 +8
Branches 364 322 -42
==========================================
+ Hits 1219 1224 +5
- Misses 783 787 +4
+ Partials 84 83 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks for working on this Chris 💯. The bvals and bvecs have not been truncated, though, and even if the test is passing, the gradient direction may not correspond to the one that is displayed. IMO best would be to rename the DWI test file to clearly state that its has been truncated (and to reduce confusion with the original image on OpenNeuro), and add the matching bval/bvec pair. Can you please do this @effigies ? |
Thanks Chris. Merging. |
Add DWI volume plot method.