Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use absolute dir for mkbootimg symlink #137

Merged
merged 2 commits into from
Jul 6, 2024
Merged

Don't use absolute dir for mkbootimg symlink #137

merged 2 commits into from
Jul 6, 2024

Commits on Jul 4, 2024

  1. vendor: mkbootimg: Use builtin ${CMAKE_INSTALL_BINDIR} instead of rel… 

    …ative bin

Now the bin directory can be changed using standard cmake means.

Signed-off-by: Björn Bidar <bjorn.bidar@jolla.com>
    @Thaodan
    Thaodan committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    701f861 View commit details
    Browse the repository at this point in the history

  2. vendor: Don't use absolute dir for mkbootimg symlink 

    I noticed that the absolute symlink did not work on my system when
trying to execute the script inside it's installation directory before
the package is installed.
While investigating I noticed that on SUSE the symlink gets relinked
to be relative to be relative to the install location of the symlink
after which the link works.
Using a relative link seems safer to me.

Signed-off-by: Björn Bidar <bjorn.bidar@jolla.com>
    @Thaodan
    Thaodan committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    0983183 View commit details
    Browse the repository at this point in the history