Skip to content

Commit

Permalink
chore: fix XCConfigurationList assertion (#264)
Browse files Browse the repository at this point in the history
  • Loading branch information
legendecas authored Sep 2, 2024
1 parent 0b8f5bf commit 6b93b01
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 9 deletions.
5 changes: 2 additions & 3 deletions .github/workflows/node-gyp.yml
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
name: node-gyp integration
on:
push:
branches: [ main ]
pull_request:
branches: [ main ]
workflow_dispatch:

jobs:
integration:
node-gyp-integration:
strategy:
fail-fast: false
matrix:
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
name: Node.js integration
on:
push:
branches: [ main ]
pull_request:
branches: [ main ]
workflow_dispatch:

jobs:
integration:
nodejs-integration:
strategy:
fail-fast: false
matrix:
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/python_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,9 @@
name: Python_tests
on:
push:
branches: [ main ]
pull_request:
branches: [ main ]
workflow_dispatch:

jobs:
Python_tests:
runs-on: ${{ matrix.os }}
Expand Down
2 changes: 1 addition & 1 deletion pylib/gyp/xcodeproj_file.py
Original file line number Diff line number Diff line change
Expand Up @@ -781,7 +781,7 @@ def UpdateProperties(self, properties, do_copy=False):
# Make sure the property conforms to the schema.
(is_list, property_type, is_strong) = self._schema[property][0:3]
if is_list:
if not isinstance(value.__class__, list):
if not isinstance(value, list):
raise TypeError(
property
+ " of "
Expand Down

0 comments on commit 6b93b01

Please sign in to comment.