Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Combat Update #163

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

Geo-Georgi
Copy link

This is still WIP for a combat overhaul, i am looking for feedback as this is my first pull request as well.
Current changes:

  • Added roles Default,Healer,SubDps,MainDps
  • Added concerto swap based on role where you can set the character to swap to specific role if full concerto
  • Added indicator if character receives an unswappable buff aka something that goes away on leaving the field like (yinlin,zhezhi,taoqi,mortefi etc.)
  • Added states for forte and liberation where the character can be set to await for intro or intro with unswappable buff
  • Updated the combat logic of few characters

(All added things that have value of DEFAULT have no changed logic from before hand)

I am still testing stuff and for now it works great, but i have no idea how to make it available from the GUI as config to be editable so the users can pick and chose what they want, if someone can help with that i would appreciate it.

Copy link

sonarcloud bot commented Oct 31, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant