Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webclient page scaleable, login page device-width #576

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

will-moore
Copy link
Member

I noticed that the webclient login page is really not very mobile-phone friendly as the whole page shrinks to be quite small.

At the same time, the main webclient page is completely unusable on a phone as it is NOT scaleable and you can't access the centre & right areas of the page.
This is because it has the user-scalable=no flag on the <viewport>
which is "against Web Content Accessibility Guidelines" see https://developer.mozilla.org/en-US/docs/Web/HTML/Viewport_meta_tag

Using Chrome dev tools to emulate a phone E.g. a Google Pixel 4.

Before this PR: login page is tiny and webclient page is unusable:

Screenshot 2024-08-27 at 20 42 12 Screenshot 2024-08-27 at 20 42 46

After these changes, the login page is a useful size (but still scalable) and the webclient page is usable as you can zoom (rescale) and pan around the page to access all functionality:

Screenshot 2024-08-27 at 20 45 30 Screenshot 2024-08-27 at 20 44 24 Screenshot 2024-08-27 at 20 44 55

@will-moore will-moore requested a review from knabar August 28, 2024 08:24
Copy link
Member

@knabar knabar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@knabar knabar modified the milestones: 5.28.0, 5.27.2 Aug 30, 2024
@knabar knabar merged commit 7c5ea1e into ome:master Sep 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants