webclient page scaleable, login page device-width #576
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the webclient login page is really not very mobile-phone friendly as the whole page shrinks to be quite small.
At the same time, the main webclient page is completely unusable on a phone as it is NOT scaleable and you can't access the centre & right areas of the page.
This is because it has the
user-scalable=no
flag on the<viewport>
which is "against Web Content Accessibility Guidelines" see https://developer.mozilla.org/en-US/docs/Web/HTML/Viewport_meta_tag
Using Chrome dev tools to emulate a phone E.g. a
Google Pixel 4
.Before this PR: login page is tiny and webclient page is unusable:
After these changes, the login page is a useful size (but still scalable) and the webclient page is usable as you can zoom (rescale) and pan around the page to access all functionality: