Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DiskArrays 0.4.5, Pkg update #889

Merged
merged 1 commit into from
Oct 22, 2024
Merged

DiskArrays 0.4.5, Pkg update #889

merged 1 commit into from
Oct 22, 2024

Conversation

arlowhite
Copy link
Collaborator

@arlowhite arlowhite commented Oct 22, 2024

  • free DiskArrays to ^0.4.5
  • changed DiskArrays to weakdep, which is more correct (must be dep or weakdep to set compat)
  • Set Julia compat to ^1.10 (now LTS)

Other minor package updates.

@arlowhite arlowhite linked an issue Oct 22, 2024 that may be closed by this pull request
uuid = "30363a11-5582-574a-97bb-aa9a979735b9"
version = "0.11.8"
version = "0.12.0"
Copy link
Collaborator Author

@arlowhite arlowhite Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible concern since 0.x minor update.
https://github.com/JuliaGeo/NetCDF.jl/releases
However, the reason for NetCDF 0.12 is the change to DiskArrays 0.4

@arlowhite
Copy link
Collaborator Author

Julia 1.10 tests passed

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.36%. Comparing base (15aea4c) to head (64ea706).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #889   +/-   ##
=======================================
  Coverage   49.36%   49.36%           
=======================================
  Files          70       70           
  Lines        4734     4734           
=======================================
  Hits         2337     2337           
  Misses       2397     2397           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ConnectedSystems ConnectedSystems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass, so assuming the update to NetCDF is okay.

@ConnectedSystems ConnectedSystems merged commit 9cd0523 into main Oct 22, 2024
4 checks passed
@ConnectedSystems ConnectedSystems deleted the diskarrays-update branch October 24, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DiskArrays pinned to 0.3.23
2 participants