Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCTEAM-1368: SBP series are taken from a parameter #625

Merged
merged 2 commits into from
May 14, 2024

Conversation

tomschr
Copy link
Collaborator

@tomschr tomschr commented May 8, 2024

  • Introduce a new parameter json-ld-seriesname (default empty)
  • In the regular SUSE stylesheets, it's empty it contains the value "Product & Solutions"
  • For the SBP stylesheets, this parameter is set to SUSE Best Practices

@tomschr tomschr added format-html html, xhtml, html5, webhelp, jsp support format-pdf pdf support topic-metadata Issues that deals with meta data information labels May 8, 2024
@tomschr tomschr self-assigned this May 8, 2024
@tomschr
Copy link
Collaborator Author

tomschr commented May 13, 2024

Result for SBP paper DC-SBP-GCC-12:

HTML output of DC-SBP-GCC-12

Screenshot_20240513_130832

PDF output of DC-SBP-GCC-12

Screenshot_20240513_131130

@tomschr tomschr added the styles-sbp SBP stylesheets label May 13, 2024
In the regular stylesheets:
* Introduce a new parameter json-ld-seriesname (default empty)
* Introduce add.series.name and implement the following algorithm
  for meta[@name='series']:
  * Check for non-empty $json-ld-seriesname parameter. If yes,
    use it. If not, continue
  * Check if d:info/d:meta[@name='series'] exist. If yes, use.
    If not abort.
* Adapt SASS/CSS stylesheets

For the SBP stylesheets

* Set parameter json-ld-seriesname to "SUSE Best Practices"
* Change FO/HTML stylesheet to produce a single line for each category
* Fix series and categories for SBP in cover page
  The cover page places series name and categories in the
  following way:

  Series Name ("SUSE Best Practices")
  - space -
  Category 1
  Category 2
Use "Product & Solutions" as default
@tomschr
Copy link
Collaborator Author

tomschr commented May 14, 2024

After showing it to Gayathri & Jana, both are fine.

@tomschr tomschr marked this pull request as ready for review May 14, 2024 08:45
@tomschr tomschr merged commit 64eed0b into main May 14, 2024
2 checks passed
@tomschr tomschr deleted the docteam1368-sbp-series branch May 14, 2024 08:47
tomschr added a commit that referenced this pull request May 14, 2024
Use the same algorithm as in HTML.

Ref: DOCTEAM-1368
Ref: PR #625
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
format-html html, xhtml, html5, webhelp, jsp support format-pdf pdf support styles-sbp SBP stylesheets topic-metadata Issues that deals with meta data information
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant