Add ReadRequirement for UseCases functions #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 25, 2024 16:13
Add minor update for issue opencomputeproject#53
1. Fix Invalid Profile Error - "CompareType is required for CompareProperty" but not found, 2. Handle deprecated properties using ReplacesProperty and ReplacedByProperty functions.
Apply UseCases functions for conditional requirements of ChassisType and ManagerType
Add ReadRequirement for UseCases
jcleung5549
reviewed
Nov 7, 2024
| "UseCaseKeyProperty": "ChassisType", | ||
| "UseCaseComparison": "Equal", | ||
| "UseCaseKeyValues": ["Drawer", "RackMount", "Sled"], | ||
| "ReadRequirement": "IfImplemented", |
There was a problem hiding this comment.
Remove ReadRequirement line.
jcleung5549
reviewed
Nov 7, 2024
| "UseCaseKeyProperty": "ManagerType", | ||
| "UseCaseComparison": "Equal", | ||
| "UseCaseKeyValues": ["BMC", "RackManager", "EnclosureManager"], | ||
| "ReadRequirement": "IfImplemented", |
There was a problem hiding this comment.
Remove ReadRequirement line
|
Approve to merge (with noted changes) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #69