Extended /certificates endpoint with additional SSL certs info #4882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willyborankin
requested review from
cwperks,
DarshitChanpura,
derek-ho,
nibix,
peternied,
RyanL1997 and
reta
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4882 +/- ##
==========================================
+ Coverage 71.41% 71.49% +0.07%
==========================================
Files 334 333 -1
Lines 22515 22533 +18
Branches 3585 3580 -5
==========================================
+ Hits 16080 16110 +30
+ Misses 4643 4632 -11
+ Partials 1792 1791 -1
|
cwperks
reviewed
Nov 11, 2024
|
|
||
| import java.util.Locale; | ||
|
|
||
| public enum CertificateType { |
There was a problem hiding this comment.
The main issue is the use of duplicate definitions for certificate types, which prevents the REST endpoint from providing information about transport client certificates. These certificates can be configured differently from standard transport certificates as extended SSL configuration.
cwperks
reviewed
Nov 11, 2024
| @@ -51,6 +76,10 @@ public CertificateInfo(final StreamInput in) throws IOException { | |||
|
|
|||
| @Override | |||
| public void writeTo(final StreamOutput out) throws IOException { | |||
| out.writeOptionalString(format); | |||
There was a problem hiding this comment.
Whenever reading and writing is modified, isn't it recommended to add to the end? There may be issues in a mixed cluster if a message is serialized from a newer node and communicates with an older node that doesn't understand the new values.
willyborankin
force-pushed
the
ssl-endpoint-additonal-info
branch
from
bab21d1
to
babe0dc
Compare
Enhanced the /certificates endpoint to provide more detailed information. The endpoint now lists all certificates used by each node, with additional properties for each certificate, including: - "format" - "alias" - "serial_number" - "has_private_key" Signed-off-by: Andrey Pleskach <ples@aiven.io>
willyborankin
force-pushed
the
ssl-endpoint-additonal-info
branch
from
babe0dc
to
a9d34d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enhanced the
/certificatesendpoint to provide more detailed information. The endpoint now lists all certificates used by each node, with additional properties for each certificate, including:formataliasserial_numberhas_private_keyCheck List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.