Allow setting order and hooks for test role #2374
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks for the PR! ❤️ |
eshulman2
force-pushed
the
test_operator_stages
branch
from
d749fd6
to
9e7ab2d
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e1ceb9f2cf3d47658a3de25c1ed70de8 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 39m 16s |
eshulman2
force-pushed
the
test_operator_stages
branch
3 times, most recently
from
f24ddba
to
c4de17d
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a25d6668f88443eeb5b2e354691eb8dc ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 39m 51s |
eshulman2
force-pushed
the
test_operator_stages
branch
2 times, most recently
from
c175381
to
5efbd8f
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ea84a8ceb689406f85a63f9e9f8d1718 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 39m 40s |
eshulman2
force-pushed
the
test_operator_stages
branch
3 times, most recently
from
1c61cd8
to
34ffac9
Compare
eshulman2
force-pushed
the
test_operator_stages
branch
2 times, most recently
from
c00804c
to
e6b67aa
Compare
eshulman2
requested review from
lpiwowar,
lewisdenny and
cjeanner
and removed request for
lpiwowar and
lewisdenny
eshulman2
force-pushed
the
test_operator_stages
branch
from
e6b67aa
to
d2b1fed
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e49808655fc5428d94a305a80ce4e4fa ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 49m 27s |
eshulman2
force-pushed
the
test_operator_stages
branch
from
e90571d
to
354f036
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b18567a73541443d926209a283624f10 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 58m 22s |
eshulman2
force-pushed
the
test_operator_stages
branch
from
354f036
to
26e33b6
Compare
|
recheck |
eshulman2
force-pushed
the
test_operator_stages
branch
2 times, most recently
from
0e9d6a4
to
9a7fd83
Compare
|
recheck |
eshulman2
force-pushed
the
test_operator_stages
branch
2 times, most recently
from
8c7258b
to
d11abb3
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a298fb370d914192b82b183fa6a19dbd ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 17m 49s |
|
recheck |
eshulman2
force-pushed
the
test_operator_stages
branch
from
d11abb3
to
0edced1
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3b7e156e68d64b8fa72a3df62cdb32b1 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 27m 20s |
eshulman2
force-pushed
the
test_operator_stages
branch
from
0edced1
to
36e7f70
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b68d0a7b3a8443c9abaa8083eea16d36 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 26m 33s |
There was a problem hiding this comment.
There seems to be something weird going on with the include and exclude list values:
@eshulman2 knows about this issue and supposedly already has a fix.
eshulman2
force-pushed
the
test_operator_stages
branch
from
36e7f70
to
6f46145
Compare
|
@lpiwowar pushed a fix |
eshulman2
force-pushed
the
test_operator_stages
branch
from
6f46145
to
45e5220
Compare
The linked PR for the test-oprator role introduces the concept of stages. This patch updates the job definition so that it is consuming the newly defined interface. It is required because by default only the tempest stage is enabled. Depends-On: openstack-k8s-operators/ci-framework#2374
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/9a679b468a4e495a967795c895222826 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 42m 04s |
The linked PR for the test-oprator role introduces the concept of stages. This patch updates the job definition so that it is consuming the newly defined interface. It is required because by default only the tempest stage is enabled. Depends-On: openstack-k8s-operators/ci-framework#2374
| @@ -216,3 +229,21 @@ other than the default one (e.g., `tempest-tests`, `tobiko-tests`, ...): | |||
| ``` | |||
| cifmw_test_operator_tempest_name: "post-update-tempest-tests" | |||
| ``` | |||
|
|
|||
| ### Use test operator stages | |||
There was a problem hiding this comment.
suggestion (non-blocking): I would add a text that explains the stages. I would try to imagine that I'm explaining this to somebody who has no idea what test operator stages are and does not want to dig through the code of the role.
- why is this needed?
- when do I want to use the stages?
There was a problem hiding this comment.
added a short description
| @@ -25,6 +24,20 @@ Execute tests via the [test-operator](https://openstack-k8s-operators.github.io/ | |||
| * `cifmw_test_operator_delete_logs_pod`: (Boolean) Delete tempest log pod created by the role at the end of the testing. Default value: `false`. | |||
| * `cifmw_test_operator_privileged`: (Boolean) Spawn the test pods with `allowPrivilegedEscalation: true` and default linux capabilities. This is required for certain test-operator functionalities to work properly (e.g.: `extraRPMs`, certain set of tobiko tests). Default value: `true` | |||
| * `cifmw_test_operator_selinux_level`: (String) Specify SELinux level that should be used for pods spawned with the test-operator. Note, that `cifmw_test_operator_privileged: true` must be set when this parameter has non-empty value. Default value: `s0:c478,c978` | |||
| * `cifmw_test_operator_stages`: (List) List of dictionaries defining the stages that should be used in the test operator role. List items options are: | |||
There was a problem hiding this comment.
issue (blocking): Missing default value of the cifmw_test_operator_stages variable in the README.
There was a problem hiding this comment.
it is actually there after the entire section in line 36
| ansible.builtin.stat: | ||
| path: "{{ cifmw_test_operator_controller_priv_key_file_path }}" | ||
| register: private_key_file | ||
| - name: Ensure a secret for the cifmw private key file exists |
There was a problem hiding this comment.
question: Do we really have to keep this outside of the block?
| @@ -81,47 +81,38 @@ | |||
| }}}, recursive=true) | |||
| }} | |||
|
|
|||
| - name: Check that cifmw private key file exists | |||
There was a problem hiding this comment.
issue (blocking): This task can not be removed. We have to check whether the private_key_file exists prior to the execution of the following tasks.
eshulman2
force-pushed
the
test_operator_stages
branch
from
45e5220
to
8d9ebcf
Compare
NOTE: this patch will require setting order for all jobs running not only tempest - Allow passing hook list directly to hook role - Allow setting up stages and hooks for test operator role Jira: https://issues.redhat.com/browse/OSPRH-10106
eshulman2
force-pushed
the
test_operator_stages
branch
from
8d9ebcf
to
afffa3e
Compare
The linked PR for the test-oprator role introduces the concept of stages. This patch updates the job definition so that it is consuming the newly defined interface. It is required because by default only the tempest stage is enabled. Depends-On: openstack-k8s-operators/ci-framework#2374
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/eabd473c32a849bb9a67cb39a34b8c4e ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 47m 38s |
Jira: https://issues.redhat.com/browse/OSPRH-10106