Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tempest cleanup opt #2381

Conversation

kopecmartin
Copy link
Contributor

Allow users to enable tempest cleanup feature defined in the tempest image.

openstack-k8s-operators/tcib#208
openstack-k8s-operators/test-operator#207

Allow users to enable tempest cleanup feature defined in the tempest image.

openstack-k8s-operators/tcib#208
openstack-k8s-operators/test-operator#207
@github-actions github-actions bot marked this pull request as draft September 25, 2024 09:13
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

Copy link
Contributor

@lpiwowar lpiwowar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@lpiwowar
Copy link
Contributor

/lgtm

@lewisdenny
Copy link
Collaborator

Hi @kopecmartin

This change is fine foe me, do you have a test run passing that enables this feature? I note it's disabled by default but it would be nice to see a run passing with it enabled.

lpiwowar added a commit to lpiwowar/test-operator that referenced this pull request Oct 2, 2024
This patch enables the tempest cleanup feature that cleans all
resources created during the tempest test execution.

Depends-On: openstack-k8s-operators/ci-framework#2381
@lpiwowar
Copy link
Contributor

lpiwowar commented Oct 2, 2024

Testing here -> openstack-k8s-operators/test-operator#216

@pablintino
Copy link
Collaborator

/approve

Copy link
Contributor

openshift-ci bot commented Oct 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 3, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 0f4a43e into openstack-k8s-operators:main Oct 3, 2024
6 of 7 checks passed
lpiwowar added a commit to lpiwowar/test-operator that referenced this pull request Oct 21, 2024
This patch enables the tempest cleanup feature that cleans all
resources created during the tempest test execution.

Depends-On: openstack-k8s-operators/ci-framework#2381
lpiwowar added a commit to lpiwowar/test-operator that referenced this pull request Nov 20, 2024
This patch enables the Tempest cleanup feature that cleans all
resources created during the Tempest test execution.

Depends-On: openstack-k8s-operators/ci-framework#2381
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants