Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable caching using memcached #184

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Enable caching using memcached #184

merged 1 commit into from
Aug 25, 2023

Conversation

kajinamit
Copy link
Contributor

This introduces the capability to use memcached as cache backend, to reproduce the setting in TripleO.

Enabling caching in heat provides large performance benefit in token validation and some resource queries.

@openshift-ci openshift-ci bot requested review from abays and viroel July 7, 2023 06:06
@openshift-ci openshift-ci bot added the approved label Jul 7, 2023
@kajinamit
Copy link
Contributor Author

We have to wait until openstack-k8s-operators/lib-common#298 is merged ...

@kajinamit
Copy link
Contributor Author

/test heat-operator-build-deploy-kuttl

1 similar comment
@kajinamit
Copy link
Contributor Author

/test heat-operator-build-deploy-kuttl

@kajinamit
Copy link
Contributor Author

/test heat-operator-build-deploy-kuttl

@openshift-ci openshift-ci bot added the lgtm label Jul 13, 2023
@bshephar
Copy link
Collaborator

/retest

@openshift-ci openshift-ci bot removed the lgtm label Aug 4, 2023
bshephar
bshephar reviewed Aug 4, 2023
View reviewed changes
Copy link
Collaborator

@bshephar bshephar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind updating the README with a note about this being required? We probably need some kind of automation to update the samples I used in the README. They're probably all outdated now anyway.

https://github.com/openstack-k8s-operators/heat-operator/blob/main/README.md

@kajinamit
Enable caching using memcached
590cf82 
This introduces the capability to use memcached as cache backend, to
reproduce the setting in TripleO.

Enabling caching in heat provides large performance benefit in token
validation and some resource queries.
@kajinamit
Copy link
Contributor Author

Would you mind updating the README with a note about this being required? We probably need some kind of automation to update the samples I used in the README. They're probably all outdated now anyway.

https://github.com/openstack-k8s-operators/heat-operator/blob/main/README.md

Good catch. I've updated README.
I'm wondering if we can create a sample file and import it there.

@kajinamit
Copy link
Contributor Author

/test heat-operator-build-deploy-kuttl

@openshift-ci openshift-ci bot added the lgtm label Aug 25, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bshephar, kajinamit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit b3dea63 into openstack-k8s-operators:main Aug 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bshephar bshephar bshephar approved these changes

@abays abays Awaiting requested review from abays

@viroel viroel Awaiting requested review from viroel

Assignees

@bshephar bshephar

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kajinamit @bshephar @openshift-merge-robot