Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant defaults of PasswordSelector #221

Closed
wants to merge 1 commit into from
Closed

Remove redundant defaults of PasswordSelector #221

wants to merge 1 commit into from

Conversation

kajinamit
Copy link
Contributor

We define defaults in two layers but this is redundant. This change attempts to define defaults in the single layer instead.

We define defaults in two layers but this is redundant. This change
attempts to define defaults in the single layer instead.
@kajinamit
Copy link
Contributor Author

/hold

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 8, 2023

@kajinamit: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/precommit-check 5428241 link true /test precommit-check

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bshephar, kajinamit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bshephar
Copy link
Collaborator

Looks like it's just complaining about:

 # github.com/openstack-k8s-operators/heat-operator/api/v1beta1
api/v1beta1/common_types.go:92:2: C003: Field 'Database' has both a 'Optional' kubebuilder marker with a default value and an 'omitempty' tag. Either remove the default value or remove 'omitempty'
api/v1beta1/common_types.go:96:2: C003: Field 'Service' has both a 'Optional' kubebuilder marker with a default value and an 'omitempty' tag. Either remove the default value or remove 'omitempty'
api/v1beta1/common_types.go:100:2: C003: Field 'AuthEncryptionKey' has both a 'Optional' kubebuilder marker with a default value and an 'omitempty' tag. Either remove the default value or remove 'omitempty' 

@bshephar bshephar removed the lgtm label Aug 25, 2023
@bshephar
Copy link
Collaborator

/test heat-operator-build-deploy-kuttl

@kajinamit kajinamit closed this Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants