Disable Webhooks

[bshephar]

This change builds the Operator bundle with ENABLE_WEBHOOKS=false. This is due to the duplication of webhook logic since openstack-operator imports and runs this webhook at the OpenStackControlPlane level. Therefor, having the webhook run by the service operator is a needless duplication of this webhook logic.

Jira: https://issues.redhat.com/browse/OSPRH-11198

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bshephar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [bshephar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e6ee4d6e038742faa0358b058025f546

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 01m 08s
❌ heat-operator-tempest-multinode FAILURE in 1h 11m 45s

[bshephar]

Yeah, so as we discussed on the call. This will break Kuttl tests. So we need to be able to dynamically set this for CI jobs - which is ideal since we do want to test web hooks in CI. But, ultimately, the bundle we build and ship should have the service level operator web hooks disabled so that they can be executed by the openstack-operator without duplication.

❯ curl -s "https://storage.googleapis.com/test-platform-results/pr-logs/pull/openstack-k8s-operators_heat-operator/466/pull-ci-openstack-k8s-operators-heat-operator-main-heat-operator-build-deploy-kuttl/1852209004751622144/build-log.txt" | grep "failed to call webhook"
    case.go:380: Internal error occurred: failed calling webhook "mheat.kb.io": failed to call webhook: Post "https://heat-operator-controller-manager-service.openstack-operators.svc:443/mutate-heat-openstack-org-v1beta1-heat?timeout=10s": dial tcp 10.128.0.75:9443: connect: connection refused
    case.go:380: Internal error occurred: failed calling webhook "mheat.kb.io": failed to call webhook: Post "https://heat-operator-controller-manager-service.openstack-operators.svc:443/mutate-heat-openstack-org-v1beta1-heat?timeout=10s": dial tcp 10.128.0.75:9443: connect: connection refused
    case.go:380: Internal error occurred: failed calling webhook "mheat.kb.io": failed to call webhook: Post "https://heat-operator-controller-manager-service.openstack-operators.svc:443/mutate-heat-openstack-org-v1beta1-heat?timeout=10s": dial tcp 10.128.0.75:9443: connect: connection refused

[bshephar]

/test heat-operator-build-deploy-kuttl

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/cc47398324ea43fc8a7863f7cafc5c82

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 26m 45s
❌ heat-operator-tempest-multinode FAILURE in 1h 09m 56s

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/9ac36f3b6ba341e6abf8a2fc21672ca7

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 25m 40s
❌ heat-operator-tempest-multinode FAILURE in 1h 10m 17s

[bshephar]

We need to merge this one to proceed any further here:
openshift/release#58391

[bshephar]

/test heat-operator-build-deploy-kuttl

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/589eadecd7fc49e2b4cd73a423f7c1f9

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 25m 16s
❌ heat-operator-tempest-multinode FAILURE in 1h 09m 45s

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/efff7273a75442b0941b043ecbe08afb

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 49m 58s
❌ heat-operator-tempest-multinode FAILURE in 1h 33m 40s

[openshift-ci]

@bshephar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/heat-operator-build-deploy-kuttl	a0bd52f	link	true	/test heat-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1dfbed4e2db6453e9a382f5526c704d4

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 54m 15s
❌ heat-operator-tempest-multinode FAILURE in 1h 34m 58s