Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create 2 dummy temporary flavors #221

Conversation

kopecmartin
Copy link
Contributor

discover-tempest-config needs 2 flavors it can't run without. When ran without "--create" param, it can't create the flavors itself and fails.

Let's create 2 flavors and delete them afterwards to leave the system intact.

discover-tempest-config needs 2 flavors it can't run without.
When ran without "--create" param, it can't create the flavors
itself and fails.

Let's create 2 flavors and delete them afterwards to leave
the system intact.
lpiwowar added a commit to lpiwowar/test-operator that referenced this pull request Oct 21, 2024
@lpiwowar
Copy link
Contributor

Testing here -> openstack-k8s-operators/test-operator#216

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/90bf4b6c7d904ccaa49fc420ff7501eb

✔️ openstack-meta-content-provider SUCCESS in 3h 29m 36s
tcib-crc-podified-edpm-baremetal FAILURE in 1h 25m 52s
✔️ tcib-podified-multinode-edpm-deployment-crc SUCCESS in 1h 17m 59s

Copy link
Contributor

@lpiwowar lpiwowar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

I've tested the change here and it seems to be working [1]. It would be nice if there was other solution than creating and deleting the flavors but we've already discussed this with Martin and this is probably the best solution right now.

There is a failure in deletion of the Quota for tenant [1] which is not related to this PR and can be addressed in a future if it turns out to be a problem.

[1] here

@openshift-ci openshift-ci bot added the lgtm label Oct 23, 2024
@lpiwowar lpiwowar requested review from pablintino and frenzyfriday and removed request for dprince and fultonj October 23, 2024 09:21
@lpiwowar
Copy link
Contributor

recheck

@lpiwowar
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented Oct 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: kopecmartin, lpiwowar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit fa1bec7 into openstack-k8s-operators:main Oct 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants