Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce new parameter Expected Failures List #233

Conversation

kstrenkova
Copy link
Contributor

The Expected Failures List parameter will help with specifying set of tests whose failures we want to ignore. By adding test to this list, its failure will not have impact on the jobs pass/fail. It can help with not having to re-run long running jobs and save time and resources in specific cases, for example when dealing with flaky tests.

Copy link

openshift-ci bot commented Oct 23, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/918dc73f968740f2a78daa44b2ab6db8

openstack-k8s-operators-content-provider FAILURE in 8m 09s
⚠️ podified-multinode-edpm-deployment-crc-test-operator SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1ce8d4f9b0414d39b1add8720663a060

openstack-k8s-operators-content-provider FAILURE in 7m 34s
⚠️ podified-multinode-edpm-deployment-crc-test-operator SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

Copy link
Collaborator

@lpiwowar lpiwowar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two small request otherwise looks good to me!:) 👍

api/v1beta1/tempest_types.go Outdated Show resolved Hide resolved
config/samples/test_v1beta1_tempest.yaml Outdated Show resolved Hide resolved
@kstrenkova kstrenkova force-pushed the add-expected-failures-list branch 2 times, most recently from 53fe9c2 to e200be9 Compare November 4, 2024 12:45
@kstrenkova
Copy link
Contributor Author

kstrenkova commented Nov 4, 2024

I have made the requested changes and changed the definition of the podified-multinode-edpm-deployment-crc-test-operator job, so it uses newly introduced parameter.

Copy link
Collaborator

@lpiwowar lpiwowar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also add Depends-On: openstack-k8s-operators/ci-framework#2513

We can test the ci-framework change together with this PR as well:).

.zuul.yaml Show resolved Hide resolved
@lpiwowar
Copy link
Collaborator

lpiwowar commented Nov 4, 2024

I have make the requested changes and changed the definition of the podified-multinode-edpm-deployment-crc-test-operator job, so it uses newly introduced parameter.

thanks! 🎉

The Expected Failures List parameter will help with specifying set
of tests whose failures we want to ignore. By adding test to this
list, its failure will not have impact on the jobs pass/fail. It
can help with not having to re-run long running jobs and save
time and resources in specific cases, for example when dealing
with flaky tests.

Depends-On: openstack-k8s-operators/ci-framework#2513
Copy link
Collaborator

@lpiwowar lpiwowar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!:) 👍 Let's wait for the tcib change to get merged first.

P.S.: If you want to improve a little bit the description of the parameter then I think it would be great to mention that the parameter does not accept regexes but only exact full test names.

@lpiwowar
Copy link
Collaborator

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/bdf785be1239412db4fc91fe6bafdddf

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 50m 16s
podified-multinode-edpm-deployment-crc-test-operator FAILURE in 1h 41m 07s

@lpiwowar
Copy link
Collaborator

recheck

@lpiwowar
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 18, 2024
@lpiwowar
Copy link
Collaborator

/approve

Copy link

openshift-ci bot commented Nov 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kstrenkova, lpiwowar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 1f917b1 into openstack-k8s-operators:main Nov 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants