-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce new parameter Expected Failures List #233
Introduce new parameter Expected Failures List #233
Conversation
Skipping CI for Draft Pull Request. |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/918dc73f968740f2a78daa44b2ab6db8 ❌ openstack-k8s-operators-content-provider FAILURE in 8m 09s |
7693d8c
to
d1c10d9
Compare
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1ce8d4f9b0414d39b1add8720663a060 ❌ openstack-k8s-operators-content-provider FAILURE in 7m 34s |
d1c10d9
to
4e87034
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two small request otherwise looks good to me!:) 👍
53fe9c2
to
e200be9
Compare
I have made the requested changes and changed the definition of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also add Depends-On: openstack-k8s-operators/ci-framework#2513
We can test the ci-framework change together with this PR as well:).
thanks! 🎉 |
The Expected Failures List parameter will help with specifying set of tests whose failures we want to ignore. By adding test to this list, its failure will not have impact on the jobs pass/fail. It can help with not having to re-run long running jobs and save time and resources in specific cases, for example when dealing with flaky tests. Depends-On: openstack-k8s-operators/ci-framework#2513
e200be9
to
356f40e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!:) 👍 Let's wait for the tcib change to get merged first.
P.S.: If you want to improve a little bit the description of the parameter then I think it would be great to mention that the parameter does not accept regexes but only exact full test names.
recheck |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/bdf785be1239412db4fc91fe6bafdddf ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 50m 16s |
recheck |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kstrenkova, lpiwowar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1f917b1
into
openstack-k8s-operators:main
The Expected Failures List parameter will help with specifying set of tests whose failures we want to ignore. By adding test to this list, its failure will not have impact on the jobs pass/fail. It can help with not having to re-run long running jobs and save time and resources in specific cases, for example when dealing with flaky tests.