Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luci-base: add PKG_LICENSE_FILES references to this packages #7115

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

feckert
Copy link
Member

@feckert feckert commented May 10, 2024

Description:
@jow-
According to the Apache-2.0 license, the information saved in the NOTICE files must be mentioned.
Since the LICENSE and NOTICE files are in the top-level directory of the repository, they do not belong to a specific package and are not therefor referenced.
This pullrequest changes this so that the LICENSE and NOTICE files belong to the luci-base and are therefore referenced as requested.

  • This PR is not from my main or master branch 💩, but a separate branch ✅
  • Each commit has a valid ✒️ Signed-off-by: <my@email.address> row (via git commit --signoff)
  • Each commit and PR title has a valid 📝 <package name>: title first line subject for packages
  • Description: (describe the changes proposed in this PR)

With this change, packages that do not have the source files in the
generic location (luasrc,ucode,htdocs,root,src) can still copy there
build files into the build directory if they add the following make
target 'Build/Prepare/<luci-packages-name>' to the Makefile.

Signed-off-by: Florian Eckert <fe@dev.tdt.de>
Copy the licenses file for luci into the build tree for further processing.
This is achieved by the new additional prepare handling, that was added
with commit '3b135c381cd5e5efd10353b76344e33e5230c870'.

Signed-off-by: Florian Eckert <fe@dev.tdt.de>
The 'luci-base' package is the base package that must always be installed
when the LuCI is used. Therefore, according to the license, the license
files used by the LuCI must be referenced there.

Signed-off-by: Florian Eckert <fe@dev.tdt.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant