Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

luci-app-dawn: Add configuration page #7219

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

luci-app-dawn: Add configuration page #7219

wants to merge 1 commit into from
+511 −5

Conversation

findlayfeng
Copy link
Contributor

@findlayfeng findlayfeng commented Jul 31, 2024 •
edited
Loading

Add the configuration page under the network path
Move hearing_map and network_overview pages to status path

  • This PR is not from my main or master branch 💩, but a separate branch ✅
  • Each commit has a valid ✒️ Signed-off-by: <my@email.address> row (via git commit --signoff)
  • Each commit and PR title has a valid 📝 <package name>: title first line subject for packages
  • Incremented 🆙 any PKG_VERSION in the Makefile
  • Tested on: (architecture, openwrt version, browser) ✅
  • ( Preferred ) Mention: @ the original code author for feedback
  • ( Preferred ) Screenshot or mp4 of changes:
  • ( Optional ) Closes: e.g. openwrt/luci#issue-number
  • ( Optional ) Depends on: e.g. openwrt/packages#pr-number in sister repo
  • Description: (describe the changes proposed in this PR)

@findlayfeng
luci-app-dawn: Add configuration page
e8f059d 
Add the configuration page under the network path
Move hearing_map and network_overview pages to status path

Signed-off-by: Feng Cheng <fengcheng@lidig.com>
@systemcrash
Copy link
Contributor

Could you provide a few overview screenshots please @findlayfeng ?

@systemcrash
Copy link
Contributor

ping @findlayfeng

@findlayfeng
Copy link
Contributor Author

dawn

@systemcrash
Copy link
Contributor

We absolutely shall not use default values anywhere. Those first variables in the screen shot (thank you) don't have any placeholder values. What are the units for bandwidth? What is a collision domain? Is iv - init vector?

There's no value type or error checking for fields. Do the IP fields only take ipv4 and some random text appended to them? Or must they be strictly ipv4? ipv6?

@systemcrash
Copy link
Contributor

ping @findlayfeng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@findlayfeng @systemcrash