luci-proto-3g/ppp/pppossh: fix being unable to set keepalive to 0 #7392
+18
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
systemcrash
reviewed
Nov 14, 2024
protocols/luci-proto-3g/htdocs/luci-static/resources/protocol/3g.js
Outdated
Show resolved
Hide resolved
Since on openwrt keepalive option defaults to "5 1" when it's not defined (https://github.com/openwrt/openwrt/blob/6720c4ccba256186bf2f1b1edadb851c447e62a5/package/network/services/ppp/files/ppp.sh#L128). Users must be able to set it to 0 to ignore connection failures. Signed-off-by: Erdem Gez <perport@perport.net>
Preport
force-pushed
the
fix-ppp-no-keepalive
branch
from
7fbe676
to
765d247
Compare
systemcrash
reviewed
Nov 14, 2024
| if (f == null || f == '' || isNaN(f)) | ||
| f = 0; | ||
| if (f === '' || isNaN(f)) | ||
| f = null; | ||
|
|
||
| if (i == null || i == '' || isNaN(i) || i < 1) |
There was a problem hiding this comment.
Can't interval be zero also? I don't know for sure. I get the impression that setting it to zero should turn it off. Does that happen in the init scripts?
There was a problem hiding this comment.
As long as failure is less than zero it should work.
There was a problem hiding this comment.
As long as failure is less than zero it should work.
This just means that setting it to zero disables it (in the init scipt) - which is inaccessible with thei < 1 behaviour. I'm not nit-picking your code- just what's going on here in general. That whole logic could do with a rewrite. Are you game?
|
@feckert do you also use some flavour of PPP? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since on openwrt keepalive option defaults to "5 1" when it's not defined
(see https://github.com/openwrt/openwrt/blob/6720c4ccba256186bf2f1b1edadb851c447e62a5/package/network/services/ppp/files/ppp.sh#L128).
Users must be able to set it to 0 to ignore connection failures.
Signed-off-by: <my@email.address>row (viagit commit --signoff)<package name>: titlefirst line subject for packages